Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
da1ec6583a spapr_pci: don't create 64-bit MMIO window if we don't need to
f9e9150977 spapr_pci: convert sprintf() to g_strdup_printf()

=== OUTPUT BEGIN ===
Checking PATCH 1/2: spapr_pci: convert sprintf() to g_strdup_printf()...
Checking PATCH 2/2: spapr_pci: don't create 64-bit MMIO window if we don't need 
to...
ERROR: spaces required around that '-' (ctx:VxV)
#54: FILE: hw/ppc/spapr_pci.c:1650:
+    if (sphb->mem64_win_pciaddr != (hwaddr)-1) {
                                            ^

ERROR: spaces required around that '-' (ctx:VxV)
#61: FILE: hw/ppc/spapr_pci.c:1657:
+        if (sphb->mem64_win_addr != (hwaddr)-1) {
                                             ^

total: 2 errors, 0 warnings, 26 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden