[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 2/3] hmp: fix "dump-quest-memory" segfault (arm
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [PATCH v2 2/3] hmp: fix "dump-quest-memory" segfault (arm) |
Date: |
Mon, 11 Sep 2017 15:39:01 +0100 |
On 11 September 2017 at 15:20, Laurent Vivier <address@hidden> wrote:
> Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault)
> fixes the problem for i386, do the same for arm.
>
> Running QEMU with
> qemu-system-aarch64 -M none -nographic -m 256
> and executing
> dump-guest-memory /dev/null 0 8192
> results in segfault
>
> Fix by checking if we have CPU.
>
> Signed-off-by: Laurent Vivier <address@hidden>
It seems a little arbitrary to assume that if there's no
CPU what you wanted was a 32-bit little-endian dump.
Why do we have a machine without a CPU anyway ?
thanks
-- PMM
[Qemu-ppc] [PATCH v2 3/3] tests/hmp: test "none" machine with memory, Laurent Vivier, 2017/09/11