|
| From: | Philippe Mathieu-Daudé |
| Subject: | Re: [Qemu-ppc] [Qemu-trivial] [PATCH 23/34] hw/dma/i8257: rename DMA_init() to i8257_dma_init() |
| Date: | Fri, 22 Sep 2017 15:08:03 -0300 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/22/2017 02:43 PM, Hervé Poussineau wrote:
Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit :
[...]
+void i8257_dma_init(ISABus *bus, int high_page_enable); +As you're changing the DMA_init prototype, can you add an Error **errp parameter, and pass &error_abort in each caller?See http://lists.gnu.org/archive/html/qemu-devel/2017-09/msg00262.html for more details
If Eduardo doesn't have a patch ready I can do it.
| [Prev in Thread] | Current Thread | [Next in Thread] |