[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [RFC for-2.12 5/8] spapr: Assume msi_nonbroken
From: |
David Gibson |
Subject: |
[Qemu-ppc] [RFC for-2.12 5/8] spapr: Assume msi_nonbroken |
Date: |
Mon, 11 Dec 2017 18:08:05 +1100 |
We conditionally adjust part of the guest device tree based on the
global msi_nonbroken flag. However, the main machine type code
initializes msi_nonbroken to true and there's nothing that would set
it to false again.
So replace the test with an assert().
Signed-off-by: David Gibson <address@hidden>
---
hw/ppc/spapr.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 4e4cf35587..e206825ed9 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -944,9 +944,8 @@ static void spapr_dt_rtas(sPAPRMachineState *spapr, void
*fdt)
_FDT(fdt_setprop_cell(fdt, rtas, "rtas-event-scan-rate",
RTAS_EVENT_SCAN_RATE));
- if (msi_nonbroken) {
- _FDT(fdt_setprop(fdt, rtas, "ibm,change-msix-capable", NULL, 0));
- }
+ g_assert(msi_nonbroken);
+ _FDT(fdt_setprop(fdt, rtas, "ibm,change-msix-capable", NULL, 0));
/*
* According to PAPR, rtas ibm,os-term does not guarantee a return
--
2.14.3
- Re: [Qemu-ppc] [RFC for-2.12 2/8] spapr: Capabilities infrastructure, (continued)
[Qemu-ppc] [RFC for-2.12 1/8] spapr: Rename machine init functions for clarity, David Gibson, 2017/12/11
[Qemu-ppc] [RFC for-2.12 5/8] spapr: Assume msi_nonbroken,
David Gibson <=
[Qemu-ppc] [RFC for-2.12 7/8] spapr: Handle VMX/VSX presence as an spapr capability flag, David Gibson, 2017/12/11
[Qemu-ppc] [RFC for-2.12 6/8] target/ppc: Clean up probing of VMX, VSX and DFP availability on KVM, David Gibson, 2017/12/11