[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 20/28] hw/block/pflash_cfi02: Spli
From: |
Alistair Francis |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 20/28] hw/block/pflash_cfi02: Split if() condition |
Date: |
Fri, 28 Jun 2019 16:06:34 -0700 |
On Thu, Jun 27, 2019 at 1:44 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> Split the if() condition check and arrange the indentation to
> ease the review of the next patches. No logical change.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/block/pflash_cfi02.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
> index a0d3bd60dc..08b2bc83cb 100644
> --- a/hw/block/pflash_cfi02.c
> +++ b/hw/block/pflash_cfi02.c
> @@ -309,8 +309,10 @@ static void pflash_write(void *opaque, hwaddr offset,
> uint64_t value,
>
> trace_pflash_io_write(offset, width, width << 1, value, pfl->wcycle);
> cmd = value;
> - if (pfl->cmd != 0xA0 && cmd == 0xF0) {
> - goto reset_flash;
> + if (pfl->cmd != 0xA0) {
> + if (cmd == 0xF0) {
> + goto reset_flash;
> + }
> }
> offset &= pfl->chip_len - 1;
>
> --
> 2.20.1
>
>
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 14/28] hw/block/pflash_cfi02: Remove pointless local variable, (continued)
- [Qemu-ppc] [PATCH v5 15/28] hw/block/pflash_cfi02: Document the current CFI values, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-ppc] [PATCH v5 13/28] tests/pflash-cfi02: Refactor to support testing multiple configurations, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-ppc] [PATCH v5 16/28] hw/block/pflash_cfi02: Hold the PRI table offset in a variable, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-ppc] [PATCH v5 17/28] hw/block/pflash_cfi02: Document 'Page Mode' operations are not supported, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-ppc] [PATCH v5 20/28] hw/block/pflash_cfi02: Split if() condition, Philippe Mathieu-Daudé, 2019/06/27
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 20/28] hw/block/pflash_cfi02: Split if() condition,
Alistair Francis <=
- [Qemu-ppc] [PATCH v5 19/28] hw/block/pflash_cfi02: Extract pflash_regions_count(), Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-ppc] [PATCH v5 18/28] hw/block/pflash_cfi02: Implement nonuniform sector sizes, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-ppc] [PATCH v5 22/28] hw/block/pflash_cfi02: Fix reset command not ignored during erase, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-ppc] [PATCH v5 21/28] hw/block/pflash_cfi02: Fix CFI in autoselect mode, Philippe Mathieu-Daudé, 2019/06/27
- [Qemu-ppc] [PATCH v5 25/28] hw/block/pflash_cfi02: Use chip erase time specified in the CFI table, Philippe Mathieu-Daudé, 2019/06/27