Re: [PATCH v3 34/34] spapr: Remove last pieces of SpaprIrq

[David Gibson]

On Thu, Oct 03, 2019 at 08:31:11AM +1000, David Gibson wrote:
> On Wed, Oct 02, 2019 at 12:20:35PM +0200, Greg Kurz wrote:
> > On Wed,  2 Oct 2019 12:52:08 +1000
> > David Gibson <address@hidden> wrote:
> > 
> > > The only thing remaining in this structure are the flags to allow either
> > > XICS or XIVE to be present.  These actually make more sense as spapr
> > > capabilities - that way they can take advantage of the existing
> > > infrastructure to sanity check capability states across migration and so
> > > forth.
> > > 
> > > Signed-off-by: David Gibson <address@hidden>
> > > ---
> > 
> > This needs some more care. Incoming migration of older existing machine
> > types breaks:
> > 
> > qemu-system-ppc64: cap-xics higher level (1) in incoming stream than on 
> > destination (0)
> > qemu-system-ppc64: error while loading state for instance 0x0 of device 
> > 'spapr'
> > qemu-system-ppc64: load of migration failed: Invalid argument
> 
> Ah, right, thanks for testing that.  What machine type exactly was
> broken?

Never mind, found it.  And in fact it was broken with the lastest
machine type and ic-mode=xics as well.  Turns out I wrote the
vmstatedescription for the new caps, but didn't wire them up.

It's a real pain the number of places that need to be adjusted to get
a new cap properly working, unfortunately, I've not come up with a
good way to avoid it.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature