[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] eliminate remaining places that abuse memory_region_allo
From: |
Igor Mammedov |
Subject: |
Re: [PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory() |
Date: |
Mon, 21 Oct 2019 11:18:28 +0200 |
On Mon, 21 Oct 2019 10:59:56 +0200
Philippe Mathieu-Daudé <address@hidden> wrote:
> Hi Igor,
>
> On 10/8/19 1:33 PM, Igor Mammedov wrote:
> > Series cleans up remaining boards that call
> > memory_region_allocate_system_memory()
> > multiple times, violating interface contract (the function should be called
> > only
> > once).
> >
> > With that cleaned up, it should be possible to switch from adhoc RAM
> > allocation
> > in memory_region_allocate_system_memory()->allocate_system_memory_nonnuma()
> > to
> > memory-backend based allocation, remaining roadblock for doing it is
> > deprecated
> > -mem-path fallback to RAM allocation, which is scheduled for removal at 4.3
> > merge window. So remaining patches to consolidate system RAM allocation
> > around
> > memory-backends and aliasing -mem-path/mem-prealloc to it are postponed till
> > then.
> >
> >
> > Igor Mammedov (3):
> > sparc64: use memory_region_allocate_system_memory() only for '-m'
> > specified RAM
> > ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory()
> > hppa: drop usage of memory_region_allocate_system_memory() for ROM
> >
> > hw/hppa/machine.c | 5 ++---
> > hw/ppc/rs6000_mc.c | 15 ++++++++++-----
> > hw/sparc64/niagara.c | 25 +++++++++++++------------
>
> What about the TYPE_SUN4M_MEMORY device in hw/sparc/sun4m.c?
it has only one call site so it's not issue this series targets.
I'll take care of it in follow up series, which will deal with
converting memory_region_allocate_system_memory() to memdev only
(probably I'll drop TYPE_SUN4M_MEMORY altogether)
>