[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/30] migration-test: ppc64: fix FORTH test program
From: |
Juan Quintela |
Subject: |
[PULL 06/30] migration-test: ppc64: fix FORTH test program |
Date: |
Tue, 14 Jan 2020 13:52:30 +0100 |
From: Laurent Vivier <address@hidden>
Commit e51e711b1bef has moved the initialization of start_address and
end_address after the definition of the command line argument,
where the nvramrc is initialized, and thus the loop is between 0 and 0
rather than 1 MiB and 100 MiB.
It doesn't affect the result of the test if all the tests are run in
sequence because the two first tests don't run the loop, so the
values are correctly initialized when we actually need them.
But it hangs when we ask to run only one test, for instance:
QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 \
tests/migration-test -m=quick -p /ppc64/migration/validate_uuid_error
Fixes: e51e711b1bef ("tests/migration: Add migration-test header file")
Cc: address@hidden
Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
tests/qtest/migration-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index b0580dd541..26e2e77289 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -517,14 +517,14 @@ static int test_migrate_start(QTestState **from,
QTestState **to,
} else if (strcmp(arch, "ppc64") == 0) {
machine_opts = "vsmt=8";
memory_size = "256M";
+ start_address = PPC_TEST_MEM_START;
+ end_address = PPC_TEST_MEM_END;
arch_source = g_strdup_printf("-nodefaults "
"-prom-env 'use-nvramrc?=true' -prom-env
"
"'nvramrc=hex .\" _\" begin %x %x "
"do i c@ 1 + i c! 1000 +loop .\" B\" 0 "
"until'", end_address, start_address);
arch_target = g_strdup("");
- start_address = PPC_TEST_MEM_START;
- end_address = PPC_TEST_MEM_END;
} else if (strcmp(arch, "aarch64") == 0) {
init_bootfile(bootpath, aarch64_kernel, sizeof(aarch64_kernel));
machine_opts = "virt,gic-version=max";
--
2.24.1
- [PULL 00/30] Migration pull patches (take 4), Juan Quintela, 2020/01/14
- [PULL 01/30] multifd: Initialize local variable, Juan Quintela, 2020/01/14
- [PULL 02/30] multifd: Allocate uint64_t instead of ram_addr_t, Juan Quintela, 2020/01/14
- [PULL 03/30] migration-test: Add migration multifd test, Juan Quintela, 2020/01/14
- [PULL 04/30] migration: Make sure that we don't call write() in case of error, Juan Quintela, 2020/01/14
- [PULL 05/30] migration-test: introduce functions to handle string parameters, Juan Quintela, 2020/01/14
- [PULL 06/30] migration-test: ppc64: fix FORTH test program,
Juan Quintela <=
- [PULL 07/30] runstate: ignore finishmigrate -> prelaunch transition, Juan Quintela, 2020/01/14
- [PULL 08/30] ram.c: remove unneeded labels, Juan Quintela, 2020/01/14
- [PULL 09/30] migration: Rate limit inside host pages, Juan Quintela, 2020/01/14
- [PULL 10/30] migration: Fix incorrect integer->float conversion caught by clang, Juan Quintela, 2020/01/14
- [PULL 11/30] migration: Fix the re-run check of the migrate-incoming command, Juan Quintela, 2020/01/14
- [PULL 12/30] misc: use QEMU_IS_ALIGNED, Juan Quintela, 2020/01/14
- [PULL 13/30] migration: add savevm_state_handler_remove(), Juan Quintela, 2020/01/14
- [PULL 14/30] migration: savevm_state_handler_insert: constant-time element insertion, Juan Quintela, 2020/01/14
- [PULL 15/30] migration/ram: Yield periodically to the main loop, Juan Quintela, 2020/01/14
- [PULL 16/30] migration/postcopy: reduce memset when it is zero page and matches_target_page_size, Juan Quintela, 2020/01/14