[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [SPAM] Re: [PATCH 05/15] spapr: Get rid of cas_check_pvr() error rep
|
From: |
Greg Kurz |
|
Subject: |
Re: [SPAM] Re: [PATCH 05/15] spapr: Get rid of cas_check_pvr() error reporting |
|
Date: |
Tue, 15 Sep 2020 13:00:33 +0200 |
On Tue, 15 Sep 2020 13:03:13 +0300
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
> 14.09.2020 15:34, Greg Kurz wrote:
> > The cas_check_pvr() function has two purposes:
> > - finding the "best" logical PVR, ie. the most recent one supported by
> > the guest for this CPU type
> > - checking if the guest supports the real PVR of this CPU type, which
> > is just an optional extra information to workaround the lack of
> > support for "compat" mode in PR KVM
> >
> > This logic doesn't need error reporting, really. If we don't find a
> > suitable logical PVR, we return the special value 0 which is definitely
> > not a valid PVR. Let the caller decide on whether it should error out
> > or not.
>
> maybe then rename it s/cas_check_pvr/cas_find_compat_pvr/ or something like
> this?
>
Ah yes, since this function doesn't do an actual check anymore, it may
be worth changing its name.
> >
> > This doesn't change the behavior.
> >
> > Signed-off-by: Greg Kurz <groug@kaod.org>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
>
>
- Re: [PATCH 03/15] ppc: Fix return value in cpu_post_load() error path, (continued)
- [PATCH 08/15] spapr: Add a return value to spapr_drc_attach(), Greg Kurz, 2020/09/14
- [PATCH 04/15] spapr: Simplify error handling in callers of ppc_set_compat(), Greg Kurz, 2020/09/14
- [PATCH 05/15] spapr: Get rid of cas_check_pvr() error reporting, Greg Kurz, 2020/09/14
- [PATCH 06/15] spapr: Simplify error handling in do_client_architecture_support(), Greg Kurz, 2020/09/14
- [PATCH 07/15] spapr: Simplify error handling in spapr_vio_busdev_realize(), Greg Kurz, 2020/09/14
- [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id(), Greg Kurz, 2020/09/14