[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/8] hw/ppc/sam460ex: Drop use of ppcuic_init()
From: |
Peter Maydell |
Subject: |
Re: [PATCH 5/8] hw/ppc/sam460ex: Drop use of ppcuic_init() |
Date: |
Sat, 12 Dec 2020 19:55:01 +0000 |
On Sat, 12 Dec 2020 at 19:53, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> On Sat, 12 Dec 2020, Peter Maydell wrote:
> > Switch the sam460ex board to directly creating and configuring the
> > UIC, rather than doing it via the old ppcuic_init() helper function.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > hw/ppc/sam460ex.c | 70 ++++++++++++++++++++++++++++++++++++-----------
> > 1 file changed, 54 insertions(+), 16 deletions(-)
> > + if (i == 0) {
> > + sysbus_connect_irq(sbd, PPCUIC_OUTPUT_INT,
> > + ((qemu_irq
> > *)env->irq_inputs)[PPC40x_INPUT_INT]);
> > + sysbus_connect_irq(sbd, PPCUIC_OUTPUT_CINT,
> > + ((qemu_irq
> > *)env->irq_inputs)[PPC40x_INPUT_CINT]);
> > + } else {
> > + sysbus_connect_irq(sbd, PPCUIC_OUTPUT_INT,
> > + qdev_get_gpio_in(uic[0], input_ints[i]));
> > + sysbus_connect_irq(sbd, PPCUIC_OUTPUT_INT,
>
> OK got it, there's a typo here, this one should be CINT, with that it
> seems to work better.
Oops, yes. Thanks for taking the time to find my bug, I appreciate it.
-- PMM
- [PATCH 4/8] hw/ppc/ppc440_bamboo: Drop use of ppcuic_init(), (continued)
- [PATCH 4/8] hw/ppc/ppc440_bamboo: Drop use of ppcuic_init(), Peter Maydell, 2020/12/11
- [PATCH 7/8] hw/ppc/ppc405_uc: Drop use of ppcuic_init(), Peter Maydell, 2020/12/11
- [PATCH 8/8] hw/ppc: Remove unused ppcuic_init(), Peter Maydell, 2020/12/11
- [PATCH 5/8] hw/ppc/sam460ex: Drop use of ppcuic_init(), Peter Maydell, 2020/12/11
- Re: [PATCH 5/8] hw/ppc/sam460ex: Drop use of ppcuic_init(), BALATON Zoltan, 2020/12/12
- Re: [PATCH 5/8] hw/ppc/sam460ex: Drop use of ppcuic_init(),
Peter Maydell <=
- Re: [PATCH 0/8] hw/ppc: Convert UIC device to QOM, BALATON Zoltan, 2020/12/12
- Re: [PATCH 0/8] hw/ppc: Convert UIC device to QOM, David Gibson, 2020/12/14