[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/7] PPC64: Add support for the new prefixed instructions
From: |
no-reply |
Subject: |
Re: [PATCH v2 0/7] PPC64: Add support for the new prefixed instructions |
Date: |
Wed, 16 Dec 2020 01:27:49 -0800 (PST) |
Patchew URL:
20201216090804.58640-1-gromero@linux.ibm.com/">https://patchew.org/QEMU/20201216090804.58640-1-gromero@linux.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201216090804.58640-1-gromero@linux.ibm.com
Subject: [PATCH v2 0/7] PPC64: Add support for the new prefixed instructions
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20201215174815.51520-1-drjones@redhat.com ->
patchew/20201215174815.51520-1-drjones@redhat.com
- [tag update] patchew/20201215224133.3545901-1-ehabkost@redhat.com ->
patchew/20201215224133.3545901-1-ehabkost@redhat.com
* [new tag] patchew/20201216090804.58640-1-gromero@linux.ibm.com ->
patchew/20201216090804.58640-1-gromero@linux.ibm.com
Switched to a new branch 'test'
4afd921 tests/tcg: Add tests for prefixed load/store FP instructions
2f4db24 target/ppc: Add support for prefixed load/store FP instructions
09b1856 tests/tcg: Add tests for paired vector load/store instructions
84275cf target/ppc: Add support for paired vector load/store instructions
4ef6a3a tests/tcg: Add tests for prefixed load/store instructions
660dbc6 target/ppc: Add support for prefixed load/store instructions
2f816dd target/ppc: Add infrastructure for prefixed instructions
=== OUTPUT BEGIN ===
1/7 Checking commit 2f816dd856fd (target/ppc: Add infrastructure for prefixed
instructions)
2/7 Checking commit 660dbc6b7475 (target/ppc: Add support for prefixed
load/store instructions)
ERROR: open brace '{' following function declarations go on the next line
#262: FILE: target/ppc/translate.c:2980:
+static void gen_pstd(DisasContext *ctx) {
ERROR: open brace '{' following function declarations go on the next line
#274: FILE: target/ppc/translate.c:2992:
+static void gen_pstq(DisasContext *ctx) {
WARNING: line over 80 characters
#318: FILE: target/ppc/translate.c:7320:
+GEN_HANDLER_E_PREFIXED_M(paddi, 0x0E, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
WARNING: line over 80 characters
#327: FILE: target/ppc/translate.c:7383:
+GEN_HANDLER_E_PREFIXED_M(plbz, 0x22, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
WARNING: line over 80 characters
#328: FILE: target/ppc/translate.c:7384:
+GEN_HANDLER_E_PREFIXED_M(plhz, 0x28, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
WARNING: line over 80 characters
#329: FILE: target/ppc/translate.c:7385:
+GEN_HANDLER_E_PREFIXED_M(plha, 0x2a, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
WARNING: line over 80 characters
#330: FILE: target/ppc/translate.c:7386:
+GEN_HANDLER_E_PREFIXED_M(plwz, 0x20, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
WARNING: line over 80 characters
#331: FILE: target/ppc/translate.c:7387:
+GEN_HANDLER_E_PREFIXED(plwa, 0x29, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
WARNING: line over 80 characters
#334: FILE: target/ppc/translate.c:7390:
+GEN_HANDLER_E_PREFIXED_M(pstb, 0x26, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
WARNING: line over 80 characters
#335: FILE: target/ppc/translate.c:7391:
+GEN_HANDLER_E_PREFIXED_M(psth, 0x2c, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
WARNING: line over 80 characters
#336: FILE: target/ppc/translate.c:7392:
+GEN_HANDLER_E_PREFIXED_M(pstw, 0x24, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
WARNING: line over 80 characters
#337: FILE: target/ppc/translate.c:7393:
+GEN_HANDLER_E_PREFIXED(pstd, 0x3d, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
WARNING: line over 80 characters
#338: FILE: target/ppc/translate.c:7394:
+GEN_HANDLER_E_PREFIXED(pstq, 0x3c, 0xFF, 0xFF, 0x00000000, PPC_64B,
PPC2_ISA310),
total: 2 errors, 11 warnings, 306 lines checked
Patch 2/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/7 Checking commit 4ef6a3a5b704 (tests/tcg: Add tests for prefixed load/store
instructions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 120000
ERROR: do not initialise globals to 0 or NULL
#62: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:9:
+bool debug = false;
ERROR: suspicious ; after while (0)
#70: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:17:
+ } while (0);
ERROR: spaces required around that '%' (ctx:BxV)
#94: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:41:
+ op(%1, %0, offset_upper18, offset_lower16, r) \
^
ERROR: spaces required around that '%' (ctx:WxV)
#94: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:41:
+ op(%1, %0, offset_upper18, offset_lower16, r) \
^
ERROR: suspicious ; after while (0)
#97: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:44:
+ } while (0);
ERROR: open brace '{' following function declarations go on the next line
#99: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:46:
+void check_pst(uint64_t src, uint64_t dest, uint64_t dest_orig, int width) {
ERROR: spaces required around that '*' (ctx:VxV)
#101: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:48:
+ uint64_t src_mask = (width == 8) ? -1UL : (1UL << (8*width)) - 1;
^
ERROR: spaces required around that '*' (ctx:VxV)
#104: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:51:
+ dest_orig_mask = -1UL << (8*width);
^
ERROR: spaces required around that '*' (ctx:VxV)
#107: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:54:
+ dest_orig_mask = (-1UL << (8*width)) >> (8*width);
^
ERROR: spaces required around that '*' (ctx:VxV)
#107: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:54:
+ dest_orig_mask = (-1UL << (8*width)) >> (8*width);
^
ERROR: line over 90 characters
#108: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:55:
+ assert(dest == ((dest_orig & dest_orig_mask) | ((src & src_mask) <<
(8*(8-width)))));
ERROR: spaces required around that '*' (ctx:VxV)
#108: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:55:
+ assert(dest == ((dest_orig & dest_orig_mask) | ((src & src_mask) <<
(8*(8-width)))));
^
ERROR: spaces required around that '-' (ctx:VxV)
#108: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:55:
+ assert(dest == ((dest_orig & dest_orig_mask) | ((src & src_mask) <<
(8*(8-width)))));
^
ERROR: open brace '{' following function declarations go on the next line
#112: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:59:
+void test_pst_offset(int width) {
ERROR: open brace '{' following function declarations go on the next line
#182: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:129:
+void test_pst(int width) {
ERROR: open brace '{' following function declarations go on the next line
#242: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:189:
+void test_pstb(void) {
ERROR: open brace '{' following function declarations go on the next line
#247: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:194:
+void test_psth(void) {
ERROR: open brace '{' following function declarations go on the next line
#252: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:199:
+void test_pstw(void) {
ERROR: open brace '{' following function declarations go on the next line
#257: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:204:
+void test_pstd(void) {
ERROR: spaces required around that '%' (ctx:BxV)
#290: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:237:
+ op(%0, %2, offset_upper18, offset_lower16, r) \
^
ERROR: spaces required around that '%' (ctx:WxV)
#290: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:237:
+ op(%0, %2, offset_upper18, offset_lower16, r) \
^
ERROR: suspicious ; after while (0)
#293: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:240:
+ } while (0);
ERROR: open brace '{' following function declarations go on the next line
#295: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:242:
+void check_pl_z(uint64_t src, uint64_t dest, int width) {
ERROR: spaces required around that '*' (ctx:VxV)
#299: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:246:
+ src_mask = (width == 8) ? -1UL : (1UL << (8*width)) - 1;
^
ERROR: spaces required around that '*' (ctx:VxV)
#302: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:249:
+ src_mask = (width == 8) ? -1UL : -1UL << (8*(8-width));
^
ERROR: spaces required around that '-' (ctx:VxV)
#302: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:249:
+ src_mask = (width == 8) ? -1UL : -1UL << (8*(8-width));
^
ERROR: spaces required around that '*' (ctx:VxV)
#303: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:250:
+ assert(dest == (src & src_mask) >> (8*(8-width)));
^
ERROR: spaces required around that '-' (ctx:VxV)
#303: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:250:
+ assert(dest == (src & src_mask) >> (8*(8-width)));
^
ERROR: open brace '{' following function declarations go on the next line
#307: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:254:
+void check_pl_a(uint64_t src, uint64_t dest, int width) {
WARNING: Block comments use a leading /* on a separate line
#310: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:257:
+ /* TODO: docs suggest testing high-order bit of src byte/halfword/etc, but
ERROR: spaces required around that '*' (ctx:VxV)
#316: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:263:
+ sign_mask = (src & (1UL << (width*8-1))) ? -1UL << (8*width) : 0;
^
ERROR: spaces required around that '-' (ctx:VxV)
#316: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:263:
+ sign_mask = (src & (1UL << (width*8-1))) ? -1UL << (8*width) : 0;
^
ERROR: spaces required around that '*' (ctx:VxV)
#316: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:263:
+ sign_mask = (src & (1UL << (width*8-1))) ? -1UL << (8*width) : 0;
^
ERROR: spaces required around that '*' (ctx:VxV)
#318: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:265:
+ sign_mask = (src & (1UL << 63)) ? -1UL << (8*width) : 0;
^
ERROR: spaces required around that '*' (ctx:VxV)
#322: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:269:
+ src_mask = (width == 8) ? -1UL : (1UL << (8*width)) - 1;
^
ERROR: spaces required around that '*' (ctx:VxV)
#325: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:272:
+ src_mask = (width == 8) ? -1UL : -1UL << (8*(8-width));
^
ERROR: spaces required around that '-' (ctx:VxV)
#325: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:272:
+ src_mask = (width == 8) ? -1UL : -1UL << (8*(8-width));
^
ERROR: spaces required around that '*' (ctx:VxV)
#326: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:273:
+ assert(dest == (((src & src_mask) >> (8*(8-width))) | sign_mask));
^
ERROR: spaces required around that '-' (ctx:VxV)
#326: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:273:
+ assert(dest == (((src & src_mask) >> (8*(8-width))) | sign_mask));
^
ERROR: open brace '{' following function declarations go on the next line
#330: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:277:
+void test_pl_a(int width, uint64_t src, uint64_t dest_orig) {
ERROR: open brace '{' following function declarations go on the next line
#435: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:382:
+void test_pl_z(int width, uint64_t src, uint64_t dest_orig) {
ERROR: open brace '{' following function declarations go on the next line
#569: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:516:
+void test_plbz(void) {
ERROR: open brace '{' following function declarations go on the next line
#575: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:522:
+void test_plhz(void) {
ERROR: open brace '{' following function declarations go on the next line
#581: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:528:
+void test_plha(void) {
ERROR: open brace '{' following function declarations go on the next line
#587: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:534:
+void test_plwz(void) {
ERROR: open brace '{' following function declarations go on the next line
#593: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:540:
+void test_plwa(void) {
ERROR: open brace '{' following function declarations go on the next line
#599: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:546:
+void test_pld(void) {
ERROR: open brace '{' following function declarations go on the next line
#611: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:558:
+void test_pstq(void) {
ERROR: spaces required around that '%' (ctx:WxV)
#634: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:581:
+ PSTQ(22, %0, 0, 0, 0)
^
ERROR: open brace '{' following function declarations go on the next line
#665: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:612:
+void test_plq(void) {
ERROR: spaces required around that '%' (ctx:WxV)
#720: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:667:
+ PLQ(20, %2, 0, 0, 0)
^
ERROR: "(foo*)" should be "(foo *)"
#737: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:684:
+ assert(dest0a == ((uint64_t*)src)[0]);
ERROR: "(foo*)" should be "(foo *)"
#738: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:685:
+ assert(dest1a == ((uint64_t*)src)[1]);
ERROR: "(foo*)" should be "(foo *)"
#742: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:689:
+ assert(dest0a == ((uint64_t*)src)[0]);
ERROR: "(foo*)" should be "(foo *)"
#743: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:690:
+ assert(dest1a == ((uint64_t*)src)[1]);
ERROR: open brace '{' following function declarations go on the next line
#751: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:698:
+void test_plq2(void) {
ERROR: spaces required around that '%' (ctx:WxV)
#807: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:754:
+ PLQ(20, %2, 0, 0, 0)
^
ERROR: open brace '{' following function declarations go on the next line
#834: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:781:
+void test_plbz_cia(void) {
WARNING: Block comments use a leading /* on a separate line
#838: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:785:
+ PLBZ(%0, 0, 0, 8 /* skip plbz */ + 4 /* skip b */, 1)
ERROR: spaces required around that '%' (ctx:BxV)
#838: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:785:
+ PLBZ(%0, 0, 0, 8 /* skip plbz */ + 4 /* skip b */, 1)
^
ERROR: open brace '{' following function declarations go on the next line
#850: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:797:
+void test_plhz_cia(void) {
WARNING: Block comments use a leading /* on a separate line
#854: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:801:
+ PLHZ(%0, 0, 0, 8 /* skip plhz */ + 4 /* skip b */, 1)
ERROR: spaces required around that '%' (ctx:BxV)
#854: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:801:
+ PLHZ(%0, 0, 0, 8 /* skip plhz */ + 4 /* skip b */, 1)
^
ERROR: open brace '{' following function declarations go on the next line
#870: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:817:
+void test_plha_cia(void) {
WARNING: Block comments use a leading /* on a separate line
#874: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:821:
+ PLHA(%0, 0, 0, 8 /* skip plha */ + 4 /* skip b */, 1)
ERROR: spaces required around that '%' (ctx:BxV)
#874: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:821:
+ PLHA(%0, 0, 0, 8 /* skip plha */ + 4 /* skip b */, 1)
^
ERROR: open brace '{' following function declarations go on the next line
#894: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:841:
+void test_plwz_cia(void) {
WARNING: Block comments use a leading /* on a separate line
#898: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:845:
+ PLWZ(%0, 0, 0, 8 /* skip plwz */ + 4 /* skip b */, 1)
ERROR: spaces required around that '%' (ctx:BxV)
#898: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:845:
+ PLWZ(%0, 0, 0, 8 /* skip plwz */ + 4 /* skip b */, 1)
^
ERROR: open brace '{' following function declarations go on the next line
#914: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:861:
+void test_plwa_cia(void) {
WARNING: Block comments use a leading /* on a separate line
#918: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:865:
+ PLWA(%0, 0, 0, 8 /* skip plwa */ + 4 /* skip b */, 1)
ERROR: spaces required around that '%' (ctx:BxV)
#918: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:865:
+ PLWA(%0, 0, 0, 8 /* skip plwa */ + 4 /* skip b */, 1)
^
ERROR: open brace '{' following function declarations go on the next line
#938: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:885:
+void test_pld_cia(void) {
WARNING: Block comments use a leading /* on a separate line
#942: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:889:
+ PLD(%0, 0, 0, 8 /* skip pld */ + 4 /* skip b */, 1)
ERROR: spaces required around that '%' (ctx:BxV)
#942: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:889:
+ PLD(%0, 0, 0, 8 /* skip pld */ + 4 /* skip b */, 1)
^
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#962: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c:909:
+#define do_test(testname) \
+ if (debug) \
+ fprintf(stderr, "-> running test: " #testname "\n"); \
+ test_##testname(); \
+
total: 69 errors, 8 warnings, 962 lines checked
Patch 3/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/7 Checking commit 84275cf80953 (target/ppc: Add support for paired vector
load/store instructions)
ERROR: do not use C99 // comments
#85: FILE: target/ppc/mem_helper.c:554:
+ } else { // TODO: check if it's correct for BE.
ERROR: do not use C99 // comments
#114: FILE: target/ppc/mem_helper.c:583:
+ } else { // TODO: check if it's correct for BE.
WARNING: line over 80 characters
#140: FILE: target/ppc/translate.c:7401:
+GEN_HANDLER_E_PREFIXED(plxvp, 0x3A, 0xFF, 0xFF, 0x00000000, PPC_NONE,
PPC2_ISA310),
WARNING: line over 80 characters
#141: FILE: target/ppc/translate.c:7402:
+GEN_HANDLER_E_PREFIXED(pstxvp, 0x3E, 0xFF, 0xFF, 0x00000000, PPC_NONE,
PPC2_ISA310),
total: 2 errors, 2 warnings, 181 lines checked
Patch 4/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/7 Checking commit 09b18567aad4 (tests/tcg: Add tests for paired vector
load/store instructions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36:
new file mode 100644
ERROR: do not initialise globals to 0 or NULL
#50: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:10:
+bool debug = false;
ERROR: suspicious ; after while (0)
#58: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:18:
+ } while (0);
ERROR: line over 90 characters
#65: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:25:
+ ".long 58 << 26 | (" #_Tp ") << 22 | (" #_TX ") << 21 | (" #_RA ") << 16 |
(" #_d1 ");"
ERROR: open brace '{' following function declarations go on the next line
#67: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:27:
+void test_plxvp_cia(void) {
WARNING: Block comments use a leading /* on a separate line
#74: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:34:
+ PLXVP(4, 0, 0, 8 /* skip plxvp */ + 4 /* skip b */, 1, 0)
ERROR: braces {} are necessary for all arms of this statement
#112: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:72:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#115: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:75:
+ assert(v0[i] == (31 - i)); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#119: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:79:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#122: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:82:
+ assert(v1[i] == 15 - i); // FIXME
ERROR: open brace '{' following function declarations go on the next line
#126: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:86:
+void test_plxvp(void) {
ERROR: spaces required around that '%' (ctx:WxV)
#138: FILE: tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:98:
+ asm(PLXVP(3, %2, 0, 0, 0, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#143: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:103:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#146: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:106:
+ assert(v0[i] == buf[i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#150: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:110:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#153: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:113:
+ assert(v1[i] == buf[16 + i]); // FIXME
ERROR: spaces required around that '%' (ctx:WxV)
#158: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:118:
+ asm(PLXVP(3, %2, 0, 0x1000, 0, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#163: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:123:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#166: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:126:
+ assert(v0[i] == buf[32 + i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#170: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:130:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#173: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:133:
+ assert(v1[i] == buf[48 + i]); // FIXME
ERROR: spaces required around that '%' (ctx:WxV)
#179: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:139:
+ asm(PLXVP(3, %2, 0x1000, 0x1000, 0, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#184: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:144:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#187: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:147:
+ assert(v0[i] == buf[i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#191: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:151:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#194: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:154:
+ assert(v1[i] == buf[16 + i]); // FIXME
ERROR: spaces required around that '%' (ctx:WxV)
#202: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:162:
+ asm(PLXVP(3, %2, 0x3ffff, 0xf000, 0, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#207: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:167:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#210: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:170:
+ assert(v0[i] == buf[32 + i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#214: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:174:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#217: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:177:
+ assert(v1[i] == buf[48 + i]); // FIXME
ERROR: line over 90 characters
#224: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:184:
+ ".long 62 << 26 | (" #_Sp ") << 22 | (" #_SX ") << 21 | (" #_RA ") << 16 |
(" #_d1 ");"
ERROR: open brace '{' following function declarations go on the next line
#226: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:186:
+void test_pstxvp(void) {
ERROR: do not use C99 // comments
#228: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:188:
+// FIXME: reorder values for readability
ERROR: do not use C99 // comments
#235: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:195:
+// FIXME: reorder values for readability
ERROR: spaces required around that '%' (ctx:WxV)
#250: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:210:
+ asm(PSTXVP(3, %0, 0, 0, 0, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#255: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:215:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#258: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:218:
+ assert(v0[i] == buf[i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#262: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:222:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#265: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:225:
+ assert(v1[i] == buf[16 + i]); // FIXME
ERROR: spaces required around that '%' (ctx:WxV)
#270: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:230:
+ asm(PSTXVP(3, %0, 0, 0x1000, 0, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#275: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:235:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#278: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:238:
+ assert(v0[i] == buf[32 + i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#282: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:242:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#285: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:245:
+ assert(v1[i] == buf[48 + i]); // FIXME
ERROR: spaces required around that '%' (ctx:WxV)
#291: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:251:
+ asm(PSTXVP(3, %0, 0x1000, 0x1000, 0, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#296: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:256:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#299: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:259:
+ assert(v0[i] == buf[i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#303: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:263:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#306: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:266:
+ assert(v1[i] == buf[16 + i]); // FIXME
WARNING: Block comments use a leading /* on a separate line
#313: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:273:
+/* TODO: we force 2 instead of 1 in opc2 currently to hack around
ERROR: line over 90 characters
#318: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:278:
+ ".long 6 << 26 | (" #_Sp ") << 22 | (" #_SX ") << 21 | (" #_RA ") << 16 |
(" #_DQ ") << 4 | 1;"
ERROR: open brace '{' following function declarations go on the next line
#320: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:280:
+void test_stxvp(void) {
ERROR: spaces required around that '%' (ctx:WxV)
#342: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:302:
+ asm(STXVP(2, %0, 0, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#348: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:308:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#351: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:311:
+ assert(buf[i] == v0[i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#355: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:315:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#358: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:318:
+ assert(buf[16 + i] == v1[i]); // FIXME
ERROR: spaces required around that '%' (ctx:WxV)
#363: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:323:
+ asm(STXVP(2, %0, 4, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#369: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:329:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#372: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:332:
+ assert(buf[32 + i] == v0[i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#376: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:336:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#379: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:339:
+ assert(buf[48 + i] == v1[i]); // FIXME
ERROR: line over 90 characters
#387: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:347:
+ ".long 6 << 26 | (" #_Tp ") << 22 | (" #_TX ") << 21 | (" #_RA ") << 16 |
(" #_DQ ") << 4;"
ERROR: open brace '{' following function declarations go on the next line
#389: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:349:
+void test_lxvp(void) {
ERROR: spaces required around that '%' (ctx:WxV)
#401: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:361:
+ asm(LXVP(2, %2, 0, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#407: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:367:
+ if (le) {
[...]
+ } else
[...]
ERROR: do not use C99 // comments
#411: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:371:
+ assert(v0[i] == buf[i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#415: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:375:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#418: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:378:
+ assert(v1[i] == buf[16+i]); // FIXME
ERROR: spaces required around that '+' (ctx:VxV)
#418: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:378:
+ assert(v1[i] == buf[16+i]); // FIXME
^
ERROR: spaces required around that '%' (ctx:WxV)
#423: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:383:
+ asm(LXVP(2, %2, 4, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#429: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:389:
+ if (le)
[...]
+ else
[...]
ERROR: spaces required around that '+' (ctx:VxV)
#430: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:390:
+ assert(v0[i] == buf[32+16+i]);
^
ERROR: spaces required around that '+' (ctx:VxV)
#430: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:390:
+ assert(v0[i] == buf[32+16+i]);
^
ERROR: do not use C99 // comments
#432: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:392:
+ assert(v0[i] == buf[32+i]); // FIXME
ERROR: spaces required around that '+' (ctx:VxV)
#432: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:392:
+ assert(v0[i] == buf[32+i]); // FIXME
^
ERROR: braces {} are necessary for all arms of this statement
#437: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:397:
+ if (le)
[...]
+ else
[...]
ERROR: spaces required around that '+' (ctx:VxV)
#438: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:398:
+ assert(v1[i] == buf[32+i]);
^
ERROR: do not use C99 // comments
#440: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:400:
+ assert(v1[i] == buf[48+i]); // FIXME
ERROR: spaces required around that '+' (ctx:VxV)
#440: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:400:
+ assert(v1[i] == buf[48+i]); // FIXME
^
ERROR: line over 90 characters
#448: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:408:
+ ".long 31 << 26 | (" #_Tp ") << 22 | (" #_TX ") << 21 | (" #_RA ") << 16 |
(" #_RB ") << 11 | 333 << 1;"
ERROR: open brace '{' following function declarations go on the next line
#450: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:410:
+void test_lxvpx(void) {
ERROR: spaces required around that '%' (ctx:WxV)
#464: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:424:
+ asm(LXVPX(4, %2, %3, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#464: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:424:
+ asm(LXVPX(4, %2, %3, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#470: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:430:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#473: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:433:
+ assert(v0[i] == buf[i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#478: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:438:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#481: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:441:
+ assert(v1[i] == buf[16+i]); // FIXME
ERROR: spaces required around that '+' (ctx:VxV)
#481: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:441:
+ assert(v1[i] == buf[16+i]); // FIXME
^
ERROR: spaces required around that '%' (ctx:WxV)
#487: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:447:
+ asm(LXVPX(4, %2, %3, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#487: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:447:
+ asm(LXVPX(4, %2, %3, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#493: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:453:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#496: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:456:
+ assert(v0[i] == buf[32+i]); // FIXME
ERROR: spaces required around that '+' (ctx:VxV)
#496: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:456:
+ assert(v0[i] == buf[32+i]); // FIXME
^
ERROR: braces {} are necessary for all arms of this statement
#500: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:460:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#503: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:463:
+ assert(v1[i] == buf[48+i]); // FIXME
ERROR: spaces required around that '+' (ctx:VxV)
#503: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:463:
+ assert(v1[i] == buf[48+i]); // FIXME
^
ERROR: line over 90 characters
#511: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:471:
+ ".long 31 << 26 | (" #_Sp ") << 22 | (" #_SX ") << 21 | (" #_RA ") << 16 |
(" #_RB ") << 11 | 461 << 1;"
ERROR: open brace '{' following function declarations go on the next line
#513: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:473:
+void test_stxvpx(void) {
ERROR: do not use C99 // comments
#515: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:475:
+// FIXME: reorder for readability
ERROR: do not use C99 // comments
#522: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:482:
+// FIXME: ditto
ERROR: spaces required around that '%' (ctx:WxV)
#539: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:499:
+ asm(STXVPX(5, %0, %1, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#539: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:499:
+ asm(STXVPX(5, %0, %1, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#545: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:505:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#548: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:508:
+ assert(buf[i] == v0[i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#552: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:512:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#555: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:515:
+ assert(buf[16 + i] == v1[i]); // FIXME
ERROR: spaces required around that '%' (ctx:WxV)
#561: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:521:
+ asm(STXVPX(5, %0, %1, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#561: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:521:
+ asm(STXVPX(5, %0, %1, 0)
^
ERROR: braces {} are necessary for all arms of this statement
#567: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:527:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#570: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:530:
+ assert(buf[48 + i] == v1[i]); // FIXME
ERROR: braces {} are necessary for all arms of this statement
#574: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:534:
+ if (le)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#577: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:537:
+ assert(buf[32 + i] == v0[i]); // FIXME
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#584: FILE:
tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c:544:
+#define do_test(testname) \
+ if (debug) \
+ fprintf(stderr, "-> running test: " #testname "\n"); \
+ test_##testname(); \
+
total: 112 errors, 3 warnings, 582 lines checked
Patch 5/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/7 Checking commit 2f4db24b2a05 (target/ppc: Add support for prefixed
load/store FP instructions)
7/7 Checking commit 4afd9214dccd (tests/tcg: Add tests for prefixed load/store
FP instructions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
ERROR: do not initialise globals to 0 or NULL
#46: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:10:
+bool debug = false;
ERROR: suspicious ; after while (0)
#54: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:18:
+ } while (0);
ERROR: open brace '{' following function declarations go on the next line
#71: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:35:
+void test_plfs(void) {
ERROR: spaces required around that '%' (ctx:BxV)
#84: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:48:
+ PLFS(%0, %2, 0, 0, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#84: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:48:
+ PLFS(%0, %2, 0, 0, 0)
^
ERROR: open brace '{' following function declarations go on the next line
#92: FILE: tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:56:
+void test_pstfs(void) {
ERROR: spaces required around that '%' (ctx:BxV)
#106: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:70:
+ PSTFS(%1, %0, 0, 0, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#106: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:70:
+ PSTFS(%1, %0, 0, 0, 0)
^
ERROR: open brace '{' following function declarations go on the next line
#114: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:78:
+void test_plfd(void) {
ERROR: spaces required around that '%' (ctx:BxV)
#127: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:91:
+ PLFD(%0, %2, 0, 0, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#127: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:91:
+ PLFD(%0, %2, 0, 0, 0)
^
ERROR: open brace '{' following function declarations go on the next line
#135: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:99:
+void test_pstfd(void) {
ERROR: spaces required around that '%' (ctx:BxV)
#149: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:113:
+ PSTFD(%1, %0, 0, 0, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#149: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:113:
+ PSTFD(%1, %0, 0, 0, 0)
^
ERROR: open brace '{' following function declarations go on the next line
#157: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:121:
+void test_plfs_offset(void) {
ERROR: spaces required around that '%' (ctx:BxV)
#166: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:130:
+ PLFS(%0, %2, 0, 0x1, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#166: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:130:
+ PLFS(%0, %2, 0, 0x1, 0)
^
ERROR: spaces required around that '%' (ctx:BxV)
#174: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:138:
+ PLFS(%0, %2, 0x1FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#174: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:138:
+ PLFS(%0, %2, 0x1FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:BxV)
#182: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:146:
+ PLFS(%0, %2, 0x3FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#182: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:146:
+ PLFS(%0, %2, 0x3FFFF, 0xFFFF, 0)
^
ERROR: open brace '{' following function declarations go on the next line
#188: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:152:
+void test_pstfs_offset(void) {
ERROR: spaces required around that '%' (ctx:BxV)
#197: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:161:
+ PSTFS(%1, %0, 0x0, 0x1, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#197: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:161:
+ PSTFS(%1, %0, 0x0, 0x1, 0)
^
ERROR: spaces required around that '%' (ctx:BxV)
#205: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:169:
+ PSTFS(%1, %0, 0x1FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#205: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:169:
+ PSTFS(%1, %0, 0x1FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:BxV)
#213: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:177:
+ PSTFS(%1, %0, 0x3FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#213: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:177:
+ PSTFS(%1, %0, 0x3FFFF, 0xFFFF, 0)
^
ERROR: open brace '{' following function declarations go on the next line
#219: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:183:
+void test_plfd_offset(void) {
ERROR: spaces required around that '%' (ctx:BxV)
#228: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:192:
+ PLFD(%0, %2, 0, 0x1, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#228: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:192:
+ PLFD(%0, %2, 0, 0x1, 0)
^
ERROR: spaces required around that '%' (ctx:BxV)
#236: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:200:
+ PLFD(%0, %2, 0x1FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#236: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:200:
+ PLFD(%0, %2, 0x1FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:BxV)
#244: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:208:
+ PLFD(%0, %2, 0x3FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#244: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:208:
+ PLFD(%0, %2, 0x3FFFF, 0xFFFF, 0)
^
ERROR: open brace '{' following function declarations go on the next line
#250: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:214:
+void test_pstfd_offset(void) {
ERROR: spaces required around that '%' (ctx:BxV)
#259: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:223:
+ PSTFD(%1, %0, 0x0, 0x1, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#259: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:223:
+ PSTFD(%1, %0, 0x0, 0x1, 0)
^
ERROR: spaces required around that '%' (ctx:BxV)
#267: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:231:
+ PSTFD(%1, %0, 0x1FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#267: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:231:
+ PSTFD(%1, %0, 0x1FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:BxV)
#275: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:239:
+ PSTFD(%1, %0, 0x3FFFF, 0xFFFF, 0)
^
ERROR: spaces required around that '%' (ctx:WxV)
#275: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:239:
+ PSTFD(%1, %0, 0x3FFFF, 0xFFFF, 0)
^
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#281: FILE:
tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c:245:
+#define do_test(testname) \
+ if (debug) \
+ fprintf(stderr, "-> running test: " #testname "\n"); \
+ test_##testname(); \
+
total: 43 errors, 1 warnings, 283 lines checked
Patch 7/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20201216090804.58640-1-gromero@linux.ibm.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201216090804.58640-1-gromero@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH v2 0/7] PPC64: Add support for the new prefixed instructions, Gustavo Romero, 2020/12/16
- [PATCH v2 1/7] target/ppc: Add infrastructure for prefixed instructions, Gustavo Romero, 2020/12/16
- [PATCH v2 3/7] tests/tcg: Add tests for prefixed load/store instructions, Gustavo Romero, 2020/12/16
- [PATCH v2 2/7] target/ppc: Add support for prefixed load/store instructions, Gustavo Romero, 2020/12/16
- [PATCH v2 4/7] target/ppc: Add support for paired vector load/store instructions, Gustavo Romero, 2020/12/16
- [PATCH v2 5/7] tests/tcg: Add tests for paired vector load/store instructions, Gustavo Romero, 2020/12/16
- [PATCH v2 6/7] target/ppc: Add support for prefixed load/store FP instructions, Gustavo Romero, 2020/12/16
- [PATCH v2 7/7] tests/tcg: Add tests for prefixed load/store FP instructions, Gustavo Romero, 2020/12/16
- Re: [PATCH v2 0/7] PPC64: Add support for the new prefixed instructions,
no-reply <=