[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] mac_oldworld: remove duplicate bus check for PPC_INPUT(e
From: |
David Gibson |
Subject: |
Re: [PATCH 1/7] mac_oldworld: remove duplicate bus check for PPC_INPUT(env) |
Date: |
Mon, 28 Dec 2020 18:06:39 +1100 |
On Sat, Dec 19, 2020 at 10:42:23AM +0000, Mark Cave-Ayland wrote:
> This condition will have already been caught when wiring the heathrow PIC
> irqs to the CPU.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/ppc/mac_oldworld.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
> index 04f98a4d81..2ead34bdf1 100644
> --- a/hw/ppc/mac_oldworld.c
> +++ b/hw/ppc/mac_oldworld.c
> @@ -251,12 +251,6 @@ static void ppc_heathrow_init(MachineState *machine)
> tbfreq = TBFREQ;
> }
>
> - /* init basic PC hardware */
> - if (PPC_INPUT(env) != PPC_FLAGS_INPUT_6xx) {
> - error_report("Only 6xx bus is supported on heathrow machine");
> - exit(1);
> - }
> -
> /* Grackle PCI host bridge */
> dev = qdev_new(TYPE_GRACKLE_PCI_HOST_BRIDGE);
> qdev_prop_set_uint32(dev, "ofw-addr", 0x80000000);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH 0/7] macio: remove PIC object property links, Mark Cave-Ayland, 2020/12/19
- [PATCH 1/7] mac_oldworld: remove duplicate bus check for PPC_INPUT(env), Mark Cave-Ayland, 2020/12/19
- Re: [PATCH 1/7] mac_oldworld: remove duplicate bus check for PPC_INPUT(env),
David Gibson <=
- [PATCH 2/7] mac_oldworld: move initialisation of grackle before heathrow, Mark Cave-Ayland, 2020/12/19
- [PATCH 3/7] macio: move heathrow PIC inside macio-oldworld device, Mark Cave-Ayland, 2020/12/19
- [PATCH 4/7] mac_newworld: delay wiring of PCI IRQs in New World machine, Mark Cave-Ayland, 2020/12/19
- [PATCH 5/7] macio: move OpenPIC inside macio-newworld device, Mark Cave-Ayland, 2020/12/19
- [PATCH 6/7] macio: wire macio GPIOs to OpenPIC using sysbus IRQs, Mark Cave-Ayland, 2020/12/19
- [PATCH 7/7] macio: don't set user_creatable to false, Mark Cave-Ayland, 2020/12/19