qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt


From: BALATON Zoltan
Subject: Re: [PATCH v6 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it
Date: Wed, 10 Mar 2021 03:36:29 +0100 (CET)

On Wed, 10 Mar 2021, Philippe Mathieu-Daudé wrote:
On 3/9/21 9:28 PM, BALATON Zoltan wrote:
To allow reusing ISA bridge emulation for vt8231_isa move the device
state of vt82c686b_isa emulation in an abstract via_isa class. This
change breaks migration back compatibility but this is not an issue
for Fuloong2E machine which is not versioned or migration supported.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/isa/vt82c686.c        | 70 ++++++++++++++++++++++------------------
 include/hw/pci/pci_ids.h |  2 +-
 2 files changed, 40 insertions(+), 32 deletions(-)

This should be OK if this other series is accepted:
"hw/usb: Extract Extract VT82C686 UHCI PCI function into new unit"
https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg03083.html

How is this patch related to that series? This one changes the isa bridge part and that makes the usb part compiled only if configured. These seem unrelated and independent to me.

Regards,
BALATON Zoltan

I'll come back to this patch after the former series is reviewed.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]