[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/20] ppc-for-6.0 queue 20210310
From: |
David Gibson |
Subject: |
Re: [PULL 00/20] ppc-for-6.0 queue 20210310 |
Date: |
Thu, 11 Mar 2021 15:56:47 +1100 |
On Thu, Mar 11, 2021 at 04:22:44AM +0100, Ivan Warren wrote:
>
> On 3/11/2021 2:47 AM, David Gibson wrote:
> >
> > Sorry, I've forgotten this issue. If you had a patch, can you resend
> > it please.
>
> Not mine.. (I reported it, but can't remember who sent it)...
>
> diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
>
> index 2609e4082e..4a05e4e544 100644
> --- a/target/ppc/cpu.h
> +++ b/target/ppc/cpu.h
> @@ -2396,8 +2396,8 @@ static inline void cpu_get_tb_cpu_state(CPUPPCState
> *env, target_ulong *pc,
> target_ulong *cs_base, uint32_t
> *flags)
> {
> *pc = env->nip;
> - *cs_base = 0;
> - *flags = env->hflags;
> + *cs_base = env->hflags;
> + *flags = 0;
> }
Ah, that one. It caused a regression, so I dropped it. I pinged
Richard Henderson about it, but I don't think I even had a reply.
I'm afraid I don't have the knowledge or the time to debug this
myself.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PULL 19/20] spapr.c: remove duplicated assert in spapr_memory_unplug_request(), (continued)
- [PULL 19/20] spapr.c: remove duplicated assert in spapr_memory_unplug_request(), David Gibson, 2021/03/09
- [PULL 16/20] spapr_pci.c: add 'unplug already in progress' message for PCI unplug, David Gibson, 2021/03/09
- [PULL 20/20] spapr.c: send QAPI event when memory hotunplug fails, David Gibson, 2021/03/09
- [PULL 18/20] target/ppc: fix icount support on Book-e vms accessing SPRs, David Gibson, 2021/03/09
- Re: [PULL 00/20] ppc-for-6.0 queue 20210310, Bin Meng, 2021/03/09
- Re: [PULL 00/20] ppc-for-6.0 queue 20210310, Ivan Warren, 2021/03/10
Re: [PULL 00/20] ppc-for-6.0 queue 20210310, Peter Maydell, 2021/03/12