Re: [PATCH] target/ppc: fix single-step exception regression

[David Gibson]

On Tue, Jun 01, 2021 at 01:27:20PM -0700, Richard Henderson wrote:
> On 6/1/21 11:02 AM, Luis Pires wrote:
> > +            if (is_jmp == DISAS_EXIT || is_jmp == DISAS_CHAIN) {
> > +                /* We have not updated nip yet, so do it now */
> > +                gen_update_nip(ctx, nip);
> > +            }
> 
> This is incorrect.  Both EXIT and CHAIN *have* updated nip, but to something
> that isn't the next instruction.  E.g. return from interrupt.

Any theories on what's actually causing the regression, then?

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature