[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/3] mv64361: Remove extra break from a switch case
From: |
David Gibson |
Subject: |
[PULL 3/3] mv64361: Remove extra break from a switch case |
Date: |
Tue, 13 Jul 2021 12:07:36 +1000 |
From: BALATON Zoltan <balaton@eik.bme.hu>
The switch case of writing PCI 1 IO base address had an extra break
statement that made part of the code unreachable. This did not cause a
problem as guests ususally leave this register at its default value.
Fixes: dcdf98a9015 ("Add emulation of Marvell MV64361 PPC system
controller")
Reported-by: Coverity (CID 1458135)
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: <20210712131259.B705B7456E3@zero.eik.bme.hu>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/pci-host/mv64361.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/pci-host/mv64361.c b/hw/pci-host/mv64361.c
index 20510d8680..92b0f5d047 100644
--- a/hw/pci-host/mv64361.c
+++ b/hw/pci-host/mv64361.c
@@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr,
uint64_t val,
case MV64340_PCI_1_IO_BASE_ADDR:
s->pci[1].io_base = val & 0x30fffffULL;
warn_swap_bit(val);
- break;
if (!(s->cpu_conf & BIT(27))) {
s->pci[1].remap[4] = (val & 0xffffULL) << 16;
}
--
2.31.1
- [PULL 0/3] ppc-for-6.1 queue 20210713, David Gibson, 2021/07/12
- [PULL 3/3] mv64361: Remove extra break from a switch case,
David Gibson <=
- [PULL 1/3] ppc/pegasos2: Allow setprop in VOF, David Gibson, 2021/07/12
- [PULL 2/3] pseries: Update SLOF firmware image, David Gibson, 2021/07/12
- Re: [PULL 0/3] ppc-for-6.1 queue 20210713, Peter Maydell, 2021/07/13
- R: [PULL 0/3] ppc-for-6.1 queue 20210713, luigi burdo, 2021/07/17
- Re: R: [PULL 0/3] ppc-for-6.1 queue 20210713, BALATON Zoltan, 2021/07/17
- R: R: [PULL 0/3] ppc-for-6.1 queue 20210713, luigi burdo, 2021/07/17
- R: R: [PULL 0/3] ppc-for-6.1 queue 20210713, luigi burdo, 2021/07/19
- Re: R: R: [PULL 0/3] ppc-for-6.1 queue 20210713, BALATON Zoltan, 2021/07/20
- R: R: R: [PULL 0/3] ppc-for-6.1 queue 20210713, luigi burdo, 2021/07/20
- Re: R: R: R: [PULL 0/3] ppc-for-6.1 queue 20210713, BALATON Zoltan, 2021/07/20