[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v12 10/16] machine: Use ms instead of global current_machine in s
From: |
Yanan Wang |
Subject: |
[PATCH v12 10/16] machine: Use ms instead of global current_machine in sanity-check |
Date: |
Wed, 29 Sep 2021 10:58:10 +0800 |
In the sanity-check of smp_cpus and max_cpus against mc in function
machine_set_smp(), we are now using ms->smp.max_cpus for the check
but using current_machine->smp.max_cpus in the error message.
Tweak this by uniformly using the local ms.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/core/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index f2a34d98c0..12d7416053 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -881,7 +881,7 @@ static void machine_set_smp(Object *obj, Visitor *v, const
char *name,
} else if (ms->smp.max_cpus > mc->max_cpus) {
error_setg(errp, "Invalid SMP CPUs %d. The max CPUs "
"supported by machine '%s' is %d",
- current_machine->smp.max_cpus,
+ ms->smp.max_cpus,
mc->name, mc->max_cpus);
}
--
2.19.1
- [PATCH v12 00/16] machine: smp parsing fixes and improvement, Yanan Wang, 2021/09/28
- [PATCH v12 01/16] qapi/machine: Fix an incorrect comment of SMPConfiguration, Yanan Wang, 2021/09/28
- [PATCH v12 07/16] qtest/numa-test: Use detailed -smp CLIs in pc_dynamic_cpu_cfg, Yanan Wang, 2021/09/28
- [PATCH v12 02/16] machine: Deprecate "parameter=0" SMP configurations, Yanan Wang, 2021/09/28
- [PATCH v12 04/16] machine: Uniformly use maxcpus to calculate the omitted parameters, Yanan Wang, 2021/09/28
- [PATCH v12 10/16] machine: Use ms instead of global current_machine in sanity-check,
Yanan Wang <=
- [PATCH v12 03/16] machine: Minor refactor/fix for the smp parsers, Yanan Wang, 2021/09/28
- [PATCH v12 06/16] machine: Improve the error reporting of smp parsing, Yanan Wang, 2021/09/28
- [PATCH v12 09/16] machine: Prefer cores over sockets in smp parsing since 6.2, Yanan Wang, 2021/09/28
- [PATCH v12 05/16] machine: Set the value of cpus to match maxcpus if it's omitted, Yanan Wang, 2021/09/28
- [PATCH v12 08/16] qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split, Yanan Wang, 2021/09/28
- [PATCH v12 13/16] machine: Remove smp_parse callback from MachineClass, Yanan Wang, 2021/09/28
- [PATCH v12 12/16] machine: Make smp_parse generic enough for all arches, Yanan Wang, 2021/09/28
- [PATCH v12 15/16] machine: Put all sanity-check in the generic SMP parser, Yanan Wang, 2021/09/28
- [PATCH v12 16/16] machine: Make smp_parse return a boolean, Yanan Wang, 2021/09/28