qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 40


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models
Date: Fri, 1 Oct 2021 14:57:00 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 10/1/21 14:46, Peter Maydell wrote:
> On Fri, 1 Oct 2021 at 13:22, Thomas Huth <thuth@redhat.com> wrote:

>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
>> index 2f7db9a98d..27c03ef624 100644
>> --- a/docs/about/deprecated.rst
>> +++ b/docs/about/deprecated.rst
>> @@ -238,6 +238,11 @@ The ``I7200`` guest CPU relies on the nanoMIPS ISA, 
>> which is deprecated
>>  (the ISA has never been upstreamed to a compiler toolchain). Therefore
>>  this CPU is also deprecated.
>>
>> +PPC 405 CPU models (since 6.2)
>> +''''''''''''''''''''''''''''''
>> +
>> +The related boards ``ref405ep`` and ``taihu`` are marked as deprecated, too.
>> +
> 
> What is this "too" a reference to? The immediately preceding section
> in the document is about the MIPS I7200 CPU model.
> 
> The not-being-deprecated sam460ex board also uses the ppc405 CPU
> I think, so I don't think we can drop the CPU models.

>> +    mc->deprecation_reason = "ppc405 CPU is deprecated";
>>  }
> 
> We're not deprecating the machine types because we're deprecating
> the CPU types. We're deprecating them because we believe that
> nobody's using them.

OTOH we mostly test default CPUs. I am a bit worried about CPU
coverage in general. I'm not suggesting we should remove old
CPUs along with their machines, because we can still test an ISA,
just worried about having so many code paths uncovered.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]