Re: [PATCH 1/4] linux-user/ppc: Fix XER access in save/restore_user_regs

[Richard Henderson]

On 10/15/21 7:54 AM, Matheus K. Ferst wrote:
> > While Appendix B does guarantee that "0" is and always will be an invalid 
> > instruction, I
> > wonder if the test itself would be clearer (i.e. self-documenting the intent) 
> > using
> > SIGTRAP and "trap".
> >
> >
> > r~
>
> It would be better, but cpu_loop is currently calling cpu_abort for POWERPC_EXCP_TRAP, so 
> the test would fail. I'll see if I can fix that in another patch, and then we can change 
> the test to use trap.

Fair enough.


r~