Re: [PATCH 11/33] target/ppc: Move vcfuged to vmx-impl.c.inc

[Richard Henderson]

On 10/21/21 12:45 PM, matheus.ferst@eldorado.org.br wrote:
> diff --git a/target/ppc/translate/vmx-impl.c.inc 
> b/target/ppc/translate/vmx-impl.c.inc
> index 92b9527aff..f0f6d561e1 100644
> --- a/target/ppc/translate/vmx-impl.c.inc
> +++ b/target/ppc/translate/vmx-impl.c.inc
> @@ -1559,6 +1559,24 @@ GEN_VXFORM3(vpermxor, 22, 0xFF)
>   GEN_VXFORM_DUAL(vsldoi, PPC_ALTIVEC, PPC_NONE,
>                   vpermxor, PPC_NONE, PPC2_ALTIVEC_207)
>   
> +static bool trans_VCFUGED(DisasContext *ctx, arg_VX *a)
> +{
> +    static const TCGOpcode vecop_list[] = { 0 };
> +    static const GVecGen3 g = {
> +        .fni8 = gen_helper_CFUGED,
> +        .opt_opc = vecop_list,
> +        .vece = MO_64,
> +    };

You only need vecop_list if you supply fniv.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~