[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 16/22] target/ppc: Move dtstdc[q]/dtstdg[q] to decodetree
|
From: |
Luis Fernando Fujita Pires |
|
Subject: |
RE: [PATCH v3 16/22] target/ppc: Move dtstdc[q]/dtstdg[q] to decodetree |
|
Date: |
Mon, 25 Oct 2021 18:52:07 +0000 |
From: Richard Henderson <richard.henderson@linaro.org>
> On 9/10/21 4:26 AM, Luis Pires wrote:
> > +&Z22_bf_fra bf fra dm
> > +@Z22_bf_fra ...... bf:3 .. fra:5 dm:6 ......... . &Z22_bf_fra
> > +
> > +%z22_frap 17:4 !function=times_2
> > +@Z22_bf_frap ...... bf:3 .. ....0 dm:6 ......... . &Z22_bf_fra
> fra=%z22_frap
>
> How confusing. There's a typo in the manual for these insns, with the minor
> opcode (XO) field at the wrong location. It's correct in the summary of
> instruction formats at the beginning of the manual.
Right! This was also the case for dscli[q]/dscri[q]. I've reported this, and it
should be fixed in the next release of the ISA.
> Functional change: you're no longer storing nip. It does seem wrong, but that
> fix should be broken out to a separate patch.
Thanks, I've moved the nip update changes to a separate patch in the new series.
--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>