Re: [PATCH v3 10/37] target/ppc: Move Vector Compare Not Equal or Zero to decodetree

[Matheus K. Ferst]

On 11/02/2022 01:41, Richard Henderson wrote:
> On 2/10/22 23:34, matheus.ferst@eldorado.org.br wrote:
> > +static void gen_vcmpnez_vec(unsigned vece, TCGv_vec t, TCGv_vec a, 
> > TCGv_vec b)
> > +{
> > +    TCGv_vec t0, t1, zero;
> > +
> > +    t0 = tcg_temp_new_vec_matching(t);
> > +    t1 = tcg_temp_new_vec_matching(t);
> > +    zero = tcg_constant_vec_matching(t, vece, 0);
> > +
> > +    tcg_gen_cmp_vec(TCG_COND_EQ, vece, t0, a, zero);
> > +    tcg_gen_cmp_vec(TCG_COND_EQ, vece, t1, b, zero);
> > +    tcg_gen_cmp_vec(TCG_COND_NE, vece, t, a, b);
> > +
> > +    tcg_gen_or_vec(vece, t, t, t0);
> > +    tcg_gen_or_vec(vece, t, t, t1);
> > +
> > +    tcg_gen_shli_vec(vece, t, t, (8 << vece) - 1);
> > +    tcg_gen_sari_vec(vece, t, t, (8 << vece) - 1);
>
> No shifting required, only the cmp.
>
> > +static bool do_vcmpnez(DisasContext *ctx, arg_VC *a, int vece)
> > +{
> > +    static const TCGOpcode vecop_list[] = {
> > +        INDEX_op_cmp_vec, INDEX_op_shli_vec, INDEX_op_sari_vec, 0
> > +    };
>
> Therefore no vecop_list required (cmp itself is mandatory).

Without vecop_list, we hit the assert in tcg_assert_listed_vecop, which 
is called from tcg_gen_cmp_vec. Am I missing something?

Thanks,
Matheus K. Ferst
Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/>
Analista de Software
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>