Re: [PATCH v3 10/12] ppc/pnv: remove pecc->rp_model

[Frederic Barrat]

On 24/06/2022 10:49, Daniel Henrique Barboza wrote:
> The attribute is unused.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---


Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com>

  Fred


>   hw/pci-host/pnv_phb4_pec.c     | 2 --
>   include/hw/pci-host/pnv_phb4.h | 1 -
>   2 files changed, 3 deletions(-)
>
> diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host/pnv_phb4_pec.c
> index 0ef66b9a9b..8dc363d69c 100644
> --- a/hw/pci-host/pnv_phb4_pec.c
> +++ b/hw/pci-host/pnv_phb4_pec.c
> @@ -260,7 +260,6 @@ static void pnv_pec_class_init(ObjectClass *klass, void 
> *data)
>       pecc->version = PNV_PHB4_VERSION;
>       pecc->phb_type = TYPE_PNV_PHB4;
>       pecc->num_phbs = pnv_pec_num_phbs;
> -    pecc->rp_model = TYPE_PNV_PHB_ROOT_PORT;
>   }
>   
>   static const TypeInfo pnv_pec_type_info = {
> @@ -313,7 +312,6 @@ static void pnv_phb5_pec_class_init(ObjectClass *klass, 
> void *data)
>       pecc->version = PNV_PHB5_VERSION;
>       pecc->phb_type = TYPE_PNV_PHB5;
>       pecc->num_phbs = pnv_phb5_pec_num_stacks;
> -    pecc->rp_model = TYPE_PNV_PHB_ROOT_PORT;
>   }
>   
>   static const TypeInfo pnv_phb5_pec_type_info = {
> diff --git a/include/hw/pci-host/pnv_phb4.h b/include/hw/pci-host/pnv_phb4.h
> index 29c49ac79c..61a0cb9989 100644
> --- a/include/hw/pci-host/pnv_phb4.h
> +++ b/include/hw/pci-host/pnv_phb4.h
> @@ -200,7 +200,6 @@ struct PnvPhb4PecClass {
>       uint64_t version;
>       const char *phb_type;
>       const uint32_t *num_phbs;
> -    const char *rp_model;
>   };
>   
>   /*