|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 02/20] ppc4xx: Introduce Ppc4xxSdramBank struct |
Date: | Sun, 4 Sep 2022 13:44:43 +0200 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 |
On 19/8/22 18:55, BALATON Zoltan wrote:
Instead of storing sdram bank parameters in unrelated arrays put them in a struct so it's clear they belong to the same bank and simplify the state struct using this bank type. Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- hw/ppc/ppc440_uc.c | 49 +++++++++++++++++----------------- hw/ppc/ppc4xx_devs.c | 59 ++++++++++++++++++++--------------------- include/hw/ppc/ppc4xx.h | 8 ++++++ 3 files changed, 61 insertions(+), 55 deletions(-)
Good idea! Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
[Prev in Thread] | Current Thread | [Next in Thread] |