[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers
From: |
Víctor Colombo |
Subject: |
Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers |
Date: |
Mon, 5 Sep 2022 13:31:14 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
On 05/09/2022 13:21, Richard Henderson wrote:
On 9/5/22 17:19, Víctor Colombo wrote:
Existing bug, but this is missing to clear fp status to start.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
Hello Richard, thanks for your review!
gen_reset_fpstatus() is called by the inline implementation in
do_helper_fsqrt() before calling the helper (patch 1).
Oops, ok.
It's probably better to move the call to inside the helper.
I did write about a scheme by which all of these calls should go away.
I guess it has
been a while...
r~
I have a message bookmarked here ([1]), but I don't know if there is a
previous one with a more in depth scheme.
Anyway, I was also analyzing recently the idea of removing all these
reset_fpstatus() calls from instructions helpers. I think this would
require to actually call it from the end of the (previous) instructions
instead of the beginning? Like adding the call to
do_float_check_status() and float_invalid_op_*() as a focal point to
'hide' the calls to reset_fpstatus(). However there are also insns
helpers that don't call these auxiliary functions, which I think would
cause the refactor to not be worthy overall.
Did you have another idea that could be simpler?
[1] https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg00064.html
--
Víctor Cora Colombo
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
- [PATCH 0/3] target/ppc: Move fsqrt[s] to decodetree, Víctor Colombo, 2022/09/05
- [PATCH 1/3] target/ppc: Move fsqrt to decodetree, Víctor Colombo, 2022/09/05
- [PATCH 2/3] target/ppc: Move fsqrts to decodetree, Víctor Colombo, 2022/09/05
- [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers, Víctor Colombo, 2022/09/05
- Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers, Richard Henderson, 2022/09/05
- Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers, Víctor Colombo, 2022/09/05
- Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers, Richard Henderson, 2022/09/05
- Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers,
Víctor Colombo <=
- Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers, Richard Henderson, 2022/09/05
- Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers, Víctor Colombo, 2022/09/06
- Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers, Richard Henderson, 2022/09/08
Re: [PATCH 0/3] target/ppc: Move fsqrt[s] to decodetree, Daniel Henrique Barboza, 2022/09/06