Re: [PATCH v2 00/18] ppc4xx_sdram QOMify and clean ups

[BALATON Zoltan]

On Tue, 13 Sep 2022, BALATON Zoltan wrote:
> This is the end of the QOMify series started by Cédric. This series
> handles the SDRAM controller models to clean them up, QOMify and unify
> them and at least partially clean up the mess that has accumulated
> around these in the past. This includes the not yet merged patches
> from the last series and new ones that change the DDR2 version used by
> sam460ex.
>
> v2: address some review comments and try to avoid compile problem with
> gcc 12.2 (untested)

Looks like I made a mistake while rebasing this and some patches were 
inadverently squashed. I'll send a v3 correcting this, please disregard 
this one.

> Regards,
> BALATON Zoltan
>
> BALATON Zoltan (18):
>  ppc440_bamboo: Remove unnecessary memsets
>  ppc4xx: Introduce Ppc4xxSdramBank struct
>  ppc4xx_sdram: Get rid of the init RAM hack
>  ppc4xx: Use Ppc4xxSdramBank in ppc4xx_sdram_banks()
>  ppc440_bamboo: Add missing 4 MiB valid memory size
>  ppc4xx_sdram: Move size check to ppc4xx_sdram_init()
>  ppc4xx_sdram: QOM'ify
>  ppc4xx_sdram: Drop extra zeros for readability
>  ppc440_sdram: Split off map/unmap of sdram banks for later reuse
>  ppc440_sdram: Implement enable bit in the DDR2 SDRAM controller
>  ppc440_sdram: Rename local variable for readibility
>  ppc440_sdram: Move RAM size check to ppc440_sdram_init
>  ppc440_sdram: QOM'ify
>  ppc4xx_sdram: Move ppc4xx DDR and DDR2 SDRAM controller models
>    together
>  ppc4xx_sdram: Use hwaddr for memory bank size
>  ppc4xx_sdram: Rename local state variable for brevity
>  ppc4xx_sdram: Generalise bank setup
>  ppc4xx_sdram: Convert DDR SDRAM controller to new bank handling
>
> hw/ppc/meson.build      |   3 +-
> hw/ppc/ppc405.h         |   8 +-
> hw/ppc/ppc405_boards.c  |  22 +-
> hw/ppc/ppc405_uc.c      |  33 +-
> hw/ppc/ppc440.h         |   4 -
> hw/ppc/ppc440_bamboo.c  |  29 +-
> hw/ppc/ppc440_uc.c      | 267 +--------------
> hw/ppc/ppc4xx_devs.c    | 413 -----------------------
> hw/ppc/ppc4xx_sdram.c   | 723 ++++++++++++++++++++++++++++++++++++++++
> hw/ppc/sam460ex.c       |  48 +--
> hw/ppc/trace-events     |   1 +
> include/hw/ppc/ppc4xx.h |  66 +++-
> 12 files changed, 847 insertions(+), 770 deletions(-)
> create mode 100644 hw/ppc/ppc4xx_sdram.c