Re: [PATCH v1 15/51] vof: add distclean target

[BALATON Zoltan]

On Thu, 29 Sep 2022, Alex Bennée wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> pc-bios/vof/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/pc-bios/vof/Makefile b/pc-bios/vof/Makefile
> index 8809c82768..990f26af31 100644
> --- a/pc-bios/vof/Makefile
> +++ b/pc-bios/vof/Makefile
> @@ -19,4 +19,6 @@ vof.elf: entry.o main.o ci.o bootmem.o libc.o
> clean:
>         rm -f *.o vof.bin vof.elf *~
>
> -.PHONY: all clean
> +distclean:
> +
> +.PHONY: all clean distclean

Shouldn't you also do something in this like at least depend on clean? By 
the way make distclean not in VOF but in QEMU build dir fails for me with:

Cleaning... 1 files.
rm -f config-host.mak qemu-bundle
rm: cannot remove 'qemu-bundle': Is a directory
make: *** [Makefile:219: distclean] Error 1

Regards,
BALATON Zoltan