[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/6] target/ppc: Remove single-step suppression inside 0x100-0xf0
From: |
Nicholas Piggin |
Subject: |
[PATCH 1/6] target/ppc: Remove single-step suppression inside 0x100-0xf00 |
Date: |
Tue, 8 Aug 2023 13:11:11 +1000 |
Single-step interrputs are suppressed if the nip is between 0x100 and
0xf00. This has been the case for a long time and it's not clear what
the intention is. Likely either an attempt to suppress trace interrupts
for instructions that cause an interrupt on completion, or a workaround
to prevent software tripping over itself single stepping its interrupt
handlers.
BookE interrupt vectors are set by IVOR registers, and BookS has AIL
modes and new interrupt types, so there are many interrupts including
the debug interrupt which can be outside this range. So any effect it
might have had does not cover most cases (including Linux on recent
BookS CPUs).
Remove this special case.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
target/ppc/translate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 74796ec7ba..06530dd782 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -7410,8 +7410,7 @@ static void ppc_tr_tb_stop(DisasContextBase *dcbase,
CPUState *cs)
}
/* Honor single stepping. */
- if (unlikely(ctx->singlestep_enabled & CPU_SINGLE_STEP)
- && (nip <= 0x100 || nip > 0xf00)) {
+ if (unlikely(ctx->singlestep_enabled & CPU_SINGLE_STEP)) {
switch (is_jmp) {
case DISAS_TOO_MANY:
case DISAS_EXIT_UPDATE:
--
2.40.1
- [PATCH for-8.2 0/6] ppc: debug facility improvements, Nicholas Piggin, 2023/08/07
- [PATCH 1/6] target/ppc: Remove single-step suppression inside 0x100-0xf00,
Nicholas Piggin <=
- [PATCH 2/6] target/ppc: Improve book3s branch trace interrupt for v2.07S, Nicholas Piggin, 2023/08/07
- [PATCH 3/6] target/ppc: Suppress single step interrupts on rfi-type instructions, Nicholas Piggin, 2023/08/07
- [PATCH 4/6] target/ppc: Implement breakpoint debug facility for v2.07S, Nicholas Piggin, 2023/08/07
- [PATCH 5/6] target/ppc: Implement watchpoint debug facility for v2.07S, Nicholas Piggin, 2023/08/07
- [PATCH 6/6] spapr: implement H_SET_MODE debug facilities, Nicholas Piggin, 2023/08/07
- Re: [PATCH for-8.2 0/6] ppc: debug facility improvements, Cédric Le Goater, 2023/08/29