[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 11/11] machine: Improve error message when using default RAM b
From: |
David Hildenbrand |
Subject: |
[PATCH v3 11/11] machine: Improve error message when using default RAM backend id |
Date: |
Wed, 23 Aug 2023 17:34:11 +0200 |
For migration purposes, users might want to reuse the default RAM
backend id, but specify a different memory backend.
For example, to reuse "pc.ram" on q35, one has to set
-machine q35,memory-backend=pc.ram
Only then, can a memory backend with the id "pc.ram" be created
manually.
Let's improve the error message.
Unfortuantely, we cannot use error_append_hint(), because the caller
passes &error_fatal.
Suggested-by: ThinerLogoer <logoerthiner1@163.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/core/machine.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index f0d35c6401..dbcd124d45 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1382,7 +1382,9 @@ void machine_run_board_init(MachineState *machine, const
char *mem_path, Error *
machine_class->default_ram_id)) {
error_setg(errp, "object name '%s' is reserved for the default"
" RAM backend, it can't be used for any other purposes."
- " Change the object's 'id' to something else",
+ " Change the object's 'id' to something else or disable"
+ " automatic creation of the default RAM backend by setting"
+ " the 'memory-backend' machine property",
machine_class->default_ram_id);
return;
}
--
2.41.0
- Re: [PATCH v3 04/11] softmmu/physmem: Remap with proper protection in qemu_ram_remap(), (continued)
- [PATCH v3 02/11] softmmu/physmem: Distinguish between file access mode and mmap protection, David Hildenbrand, 2023/08/23
- [PATCH v3 07/11] softmmu/physmem: Never return directories from file_ram_open(), David Hildenbrand, 2023/08/23
- [PATCH v3 05/11] softmmu/physmem: Bail out early in ram_block_discard_range() with readonly files, David Hildenbrand, 2023/08/23
- [PATCH v3 06/11] softmmu/physmem: Fail creation of new files in file_ram_open() with readonly=true, David Hildenbrand, 2023/08/23
- [PATCH v3 11/11] machine: Improve error message when using default RAM backend id,
David Hildenbrand <=
- Re:[PATCH v3 11/11] machine: Improve error message when using default RAM backend id, ThinerLogoer, 2023/08/25
- Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id, David Hildenbrand, 2023/08/25
- Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id, Markus Armbruster, 2023/08/25
- Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id, David Hildenbrand, 2023/08/25
- Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id, Markus Armbruster, 2023/08/25
- Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id, David Hildenbrand, 2023/08/25
- Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id, David Hildenbrand, 2023/08/25
- Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id, Philippe Mathieu-Daudé, 2023/08/29
Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id, Mario Casquero, 2023/08/29
[PATCH v3 08/11] docs: Don't mention "-mem-path" in multi-process.rst, David Hildenbrand, 2023/08/23