Re: [PATCH 7/8] target/helper: Remove unnecessary 'qemu/main-loop.h' header

[Philippe Mathieu-Daudé]

On 28/8/23 23:45, Philippe Mathieu-Daudé wrote:
> On 28/8/23 20:40, Richard Henderson wrote:
> > On 8/28/23 07:55, Philippe Mathieu-Daudé wrote:
> > > "qemu/main-loop.h" declares functions related to QEMU's
> > > main loop mutex, which these files don't access. Remove
> > > the unused "qemu/main-loop.h" header.
> > >
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > ---
> > >   target/riscv/pmu.h                   | 2 --
> > >   target/xtensa/mmu_helper.c           | 2 --
> > >   target/xtensa/op_helper.c            | 2 --
> >
> > At least these 3 files do two things.
>
> I can compile these files adding '#error' in "qemu/main-loop.h".

Doh now I got it, I also remove "exec/cpu_ldst.h". Probably
a failed rebase, sorry...