[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/71] target/alpha: Remove fallback to ev67 cpu class
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 02/71] target/alpha: Remove fallback to ev67 cpu class |
Date: |
Fri, 5 Jan 2024 16:41:55 +0100 |
From: Gavin Shan <gshan@redhat.com>
'ev67' CPU class will be returned to match everything, which makes
no sense as mentioned in the comments. Remove the logic to fall
back to 'ev67' CPU class to match everything.
Signed-off-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20231114235628.534334-2-gshan@redhat.com>
[PMD: Reword subject, replace 'any' -> 'ev67' on linux-user]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
linux-user/alpha/target_elf.h | 2 +-
target/alpha/cpu.c | 7 ++-----
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/linux-user/alpha/target_elf.h b/linux-user/alpha/target_elf.h
index 344e9f4d39..b77d638f6d 100644
--- a/linux-user/alpha/target_elf.h
+++ b/linux-user/alpha/target_elf.h
@@ -9,6 +9,6 @@
#define ALPHA_TARGET_ELF_H
static inline const char *cpu_get_model(uint32_t eflags)
{
- return "any";
+ return "ev67";
}
#endif
diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c
index 39cf841b3e..91fe8ae095 100644
--- a/target/alpha/cpu.c
+++ b/target/alpha/cpu.c
@@ -141,11 +141,8 @@ static ObjectClass *alpha_cpu_class_by_name(const char
*cpu_model)
typename = g_strdup_printf(ALPHA_CPU_TYPE_NAME("%s"), cpu_model);
oc = object_class_by_name(typename);
g_free(typename);
-
- /* TODO: remove match everything nonsense */
- if (!oc || object_class_is_abstract(oc)) {
- /* Default to ev67; no reason not to emulate insns by default. */
- oc = object_class_by_name(ALPHA_CPU_TYPE_NAME("ev67"));
+ if (!oc || !object_class_dynamic_cast(oc, TYPE_ALPHA_CPU)) {
+ return NULL;
}
return oc;
--
2.41.0
- [PULL 00/71] HW core patches for 2024-01-05, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 01/71] meson: Allow building binary with no target-specific files in hw/, Philippe Mathieu-Daudé, 2024/01/05
- [PULL 02/71] target/alpha: Remove fallback to ev67 cpu class,
Philippe Mathieu-Daudé <=
- [PULL 03/71] target/hppa: Remove object_class_is_abstract(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 04/71] cpu: Call object_class_dynamic_cast() once in cpu_class_by_name(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 05/71] cpu: Add helper cpu_model_from_type(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 06/71] cpu: Add generic cpu_list(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 07/71] target/alpha: Use generic cpu_list(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 08/71] target/arm: Use generic cpu_list(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 09/71] target/avr: Use generic cpu_list(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 10/71] target/cris: Use generic cpu_list(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 11/71] target/hexagon: Use generic cpu_list(), Philippe Mathieu-Daudé, 2024/01/05
- [PULL 12/71] target/hppa: Use generic cpu_list(), Philippe Mathieu-Daudé, 2024/01/05