[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 13/24] target/ppc/mmu_common.c: Simplify mmubooke_get_physical_ad
From: |
BALATON Zoltan |
Subject: |
[PATCH 13/24] target/ppc/mmu_common.c: Simplify mmubooke_get_physical_address() |
Date: |
Wed, 24 Apr 2024 00:31:24 +0200 (CEST) |
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
target/ppc/mmu_common.c | 25 +++++++++----------------
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
index 843f909619..d40ddb6fc3 100644
--- a/target/ppc/mmu_common.c
+++ b/target/ppc/mmu_common.c
@@ -668,31 +668,24 @@ static int mmubooke_get_physical_address(CPUPPCState
*env, mmu_ctx_t *ctx,
MMUAccessType access_type)
{
ppcemb_tlb_t *tlb;
- hwaddr raddr;
- int i, ret;
+ hwaddr raddr = (hwaddr)-1ULL;
+ int i, ret = -1;
- ret = -1;
- raddr = (hwaddr)-1ULL;
for (i = 0; i < env->nb_tlb; i++) {
tlb = &env->tlb.tlbe[i];
ret = mmubooke_check_tlb(env, tlb, &raddr, &ctx->prot, address,
access_type, i);
if (ret != -1) {
+ if (ret >= 0) {
+ ctx->raddr = raddr;
+ }
break;
}
}
-
- if (ret >= 0) {
- ctx->raddr = raddr;
- qemu_log_mask(CPU_LOG_MMU, "%s: access granted " TARGET_FMT_lx
- " => " HWADDR_FMT_plx " %d %d\n", __func__,
- address, ctx->raddr, ctx->prot, ret);
- } else {
- qemu_log_mask(CPU_LOG_MMU, "%s: access refused " TARGET_FMT_lx
- " => " HWADDR_FMT_plx " %d %d\n", __func__,
- address, raddr, ctx->prot, ret);
- }
-
+ qemu_log_mask(CPU_LOG_MMU,
+ "%s: access %s " TARGET_FMT_lx " => " HWADDR_FMT_plx
+ " %d %d\n", __func__, ret < 0 ? "refused" : "granted",
+ address, raddr, ctx->prot, ret);
return ret;
}
--
2.30.9
- [PATCH 00/24] Misc PPC exception and BookE MMU clean ups, BALATON Zoltan, 2024/04/23
- [PATCH 17/24] target/ppc/mmu_common.c: Replace hard coded constants in ppc_jumbo_xlate(), BALATON Zoltan, 2024/04/23
- [PATCH 05/24] target/ppc/mmu_common.c: Move calculation of a value closer to its usage, BALATON Zoltan, 2024/04/23
- [PATCH 11/24] target/ppc/mmu_common.c: Split off real mode cases in get_physical_address_wtlb(), BALATON Zoltan, 2024/04/23
- [PATCH 01/24] target/ppc: Fix gen_sc to use correct nip, BALATON Zoltan, 2024/04/23
- [PATCH 09/24] target/ppc/mmu_common.c: Rename get_bat_6xx_tlb(), BALATON Zoltan, 2024/04/23
- [PATCH 16/24] target/ppc/mmu_common.c: Deindent ppc_jumbo_xlate(), BALATON Zoltan, 2024/04/23
- [PATCH 18/24] target/ppc/mmu_common.c: Make get_physical_address_wtlb() static, BALATON Zoltan, 2024/04/23
- [PATCH 10/24] target/ppc/mmu_common.c: Split out BookE cases before checking real mode, BALATON Zoltan, 2024/04/23
- [PATCH 13/24] target/ppc/mmu_common.c: Simplify mmubooke_get_physical_address(),
BALATON Zoltan <=
- [PATCH 07/24] target/ppc/mmu_common.c: Drop cases for unimplemented MPC8xx MMU, BALATON Zoltan, 2024/04/23
- [PATCH 19/24] target/ppc: Move mmu_ctx_t definition to mmu_common.c, BALATON Zoltan, 2024/04/23
- [PATCH 08/24] target/ppc/mmu_common.c: Introduce mmu6xx_get_physical_address(), BALATON Zoltan, 2024/04/23
- [PATCH 02/24] target/ppc: Move patching nip from exception handler to helper_scv, BALATON Zoltan, 2024/04/23
- [PATCH 04/24] target/ppc: Remove unused helper, BALATON Zoltan, 2024/04/23
- [PATCH 15/24] target/ppc/mmu_common.c: Fix misindented qemu_log_mask() calls, BALATON Zoltan, 2024/04/23
- [PATCH 14/24] target/ppc/mmu_common.c: Simplify mmubooke206_get_physical_address(), BALATON Zoltan, 2024/04/23
- [PATCH 03/24] target/ppc: Simplify syscall exception handlers, BALATON Zoltan, 2024/04/23
- [PATCH 06/24] target/ppc/mmu_common.c: Simplify checking for real mode, BALATON Zoltan, 2024/04/23
- [PATCH 12/24] target/ppc/mmu_common.c: Inline and remove check_physical(), BALATON Zoltan, 2024/04/23