[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/5] pnv/xive2: Fail VST entry address computation if table has n
From: |
Michael Kowal |
Subject: |
[PATCH 4/5] pnv/xive2: Fail VST entry address computation if table has no VSD |
Date: |
Mon, 17 Jun 2024 15:43:01 -0500 |
From: Frederic Barrat <fbarrat@linux.ibm.com>
Fail VST entry address computatio if firmware doesn't define a descriptor
for one of the Virtualization Structure Tables (VST), there's no point in
trying to compute the address of its entry. Abort the operation and log
an error.
Signed-off-by: Michael Kowal <kowal@linux.vnet.ibm.com>
---
hw/intc/pnv_xive2.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c
index a1146311a3..e473109196 100644
--- a/hw/intc/pnv_xive2.c
+++ b/hw/intc/pnv_xive2.c
@@ -244,6 +244,11 @@ static uint64_t pnv_xive2_vst_addr(PnvXive2 *xive,
uint32_t type, uint8_t blk,
}
vsd = xive->vsds[type][blk];
+ if (vsd == 0) {
+ xive2_error(xive, "VST: vsd == 0 block id %d for VST %s %d !?",
+ blk, info->name, idx);
+ return 0;
+ }
/* Remote VST access */
if (GETFIELD(VSD_MODE, vsd) == VSD_MODE_FORWARD) {
--
2.39.3
- [PATCH 0/5] XIVE changes for Cache Watch, VSTs, STT and info pic, Michael Kowal, 2024/06/17
- [PATCH 2/5] pnv/xive2: Enable VST NVG and NVC index compression, Michael Kowal, 2024/06/17
- [PATCH 1/5] pnv/xive2: XIVE2 Cache Watch, Cache Flush and Sync Injection support, Michael Kowal, 2024/06/17
- [PATCH 4/5] pnv/xive2: Fail VST entry address computation if table has no VSD,
Michael Kowal <=
- [PATCH 5/5] pnv/xive2: Move xive2_nvp_pic_print_info() to xive2.c, Michael Kowal, 2024/06/17
- [PATCH 3/5] pnv/xive2: Set Translation Table for the NVC port space, Michael Kowal, 2024/06/17