Re: [PATCH v3 2/4] target/ppc: Move VSX vector with length storage access insns to decodetree.

[Richard Henderson]

On 6/18/24 01:58, Chinmay Rath wrote:
> Moving the following instructions to decodetree specification :
>
>          {l, st}xvl(l)           : X-form
>
> The changes were verified by validating that the tcg-ops generated by those
> instructions remain the same, which were captured using the '-d in_asm,op' flag.
>
> Also added a new function do_ea_calc_ra to calculate the effective address :
> EA <- (RA == 0) ? 0 : GPR[RA], which is now used by the above-said insns,
> and shall be used later by (p){lx, stx}vp insns.
>
> Signed-off-by: Chinmay Rath <rathc@linux.ibm.com>
> ---
>   target/ppc/helper.h                 |  8 +--
>   target/ppc/insn32.decode            |  6 ++
>   target/ppc/mem_helper.c             |  8 +--
>   target/ppc/translate.c              | 15 +++++
>   target/ppc/translate/vsx-impl.c.inc | 94 ++++++++++++++++++++---------
>   target/ppc/translate/vsx-ops.c.inc  |  8 ---
>   6 files changed, 94 insertions(+), 45 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~