Re: [PATCH 20/20] tests/functional: extend test_aarch64_virt with vulkan test

[Thomas Huth]

On 12/12/2024 13.32, Alex Bennée wrote:
> Thomas Huth <thuth@redhat.com> writes:
>
> > On 10/12/2024 21.43, Alex Bennée wrote:
> > > Now we have virtio-gpu Vulkan support lets add a test for it.
> > > Currently this is using images build by buildroot:
> > >     https://lists.buildroot.org/pipermail/buildroot/2024-December/768196.html
> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> <snip>
> > > +        self.vm.set_console()
> > > +        kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
> > > +                               'console=ttyAMA0 root=/dev/vda')
> > > +        self.require_accelerator("tcg")
> >
> > Same, please move to the beginning since it can skip the test.
> >
> > > +        self.vm.add_args("-accel", "tcg")
>
> Actually this could run under KVM if we have it for Aarch64. Can we
> represent that?

Simply omit the line "require" line and add an additional -accel kvm here? 
... I think nobody ever tried to run the functional tests with another 
accelerator beside kvm and tcg on aarch64 hosts, so it should be fine.

 Thomas