[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 22/32] tests/functional: bail aarch64_virt tests early if miss
From: |
Alex Bennée |
Subject: |
[PATCH v4 22/32] tests/functional: bail aarch64_virt tests early if missing TCG |
Date: |
Wed, 8 Jan 2025 12:10:44 +0000 |
The set_machine and require_accelerator steps can bail early so move
those to the front of the test functions. While we are at it also
clean up some long lines when adding the vm arguments.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/functional/test_aarch64_virt.py | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tests/functional/test_aarch64_virt.py
b/tests/functional/test_aarch64_virt.py
index b3d3b0ee51..201c5ed023 100755
--- a/tests/functional/test_aarch64_virt.py
+++ b/tests/functional/test_aarch64_virt.py
@@ -40,9 +40,9 @@ def test_alpine_virt_tcg_gic_max(self):
iso_path = self.ASSET_ALPINE_ISO.fetch()
self.set_machine('virt')
- self.vm.set_console()
self.require_accelerator("tcg")
+ self.vm.set_console()
self.vm.add_args("-accel", "tcg")
self.vm.add_args("-cpu", "max,pauth-impdef=on")
self.vm.add_args("-machine",
@@ -71,15 +71,16 @@ def common_aarch64_virt(self, machine):
Common code to launch basic virt machine with kernel+initrd
and a scratch disk.
"""
+ self.set_machine('virt')
+ self.require_accelerator("tcg")
+
logger = logging.getLogger('aarch64_virt')
kernel_path = self.ASSET_KERNEL.fetch()
- self.set_machine('virt')
self.vm.set_console()
kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
'console=ttyAMA0')
- self.require_accelerator("tcg")
self.vm.add_args('-cpu', 'max,pauth-impdef=on',
'-machine', machine,
'-accel', 'tcg',
@@ -100,7 +101,9 @@ def common_aarch64_virt(self, machine):
# Add the device
self.vm.add_args('-blockdev',
-
f"driver=qcow2,file.driver=file,file.filename={image_path},node-name=scratch")
+ "driver=qcow2,"
+ "file.driver=file,"
+ f"file.filename={image_path},node-name=scratch")
self.vm.add_args('-device',
'virtio-blk-device,drive=scratch')
--
2.39.5
- [PATCH v4 00/32] testing/next: functional tests, qtest clocks, vm and keymaps (pre-PR-FINAL), Alex Bennée, 2025/01/08
- [PATCH v4 01/32] tests/functional: update the arm tuxrun tests, Alex Bennée, 2025/01/08
- [PATCH v4 31/32] dockerfiles: Remove 'MAINTAINER' entry in debian-tricore-cross.docker, Alex Bennée, 2025/01/08
- [PATCH v4 18/32] tests/functional: remove hacky sleep from the tests, Alex Bennée, 2025/01/08
- [PATCH v4 07/32] tests/functional: update the mips64el tuxrun tests, Alex Bennée, 2025/01/08
- [PATCH v4 17/32] system/qtest: properly feedback results of clock_[step|set], Alex Bennée, 2025/01/08
- [PATCH v4 02/32] tests/functional: update the i386 tuxrun tests, Alex Bennée, 2025/01/08
- [PATCH v4 30/32] pc-bios: ensure keymaps dependencies set vnc tests, Alex Bennée, 2025/01/08
- [PATCH v4 11/32] tests/functional: update the riscv64 tuxrun tests, Alex Bennée, 2025/01/08
- [PATCH v4 22/32] tests/functional: bail aarch64_virt tests early if missing TCG,
Alex Bennée <=
- [PATCH v4 14/32] tests/functional: update the x86_64 tuxrun tests, Alex Bennée, 2025/01/08
- [PATCH v4 15/32] tests/functional/aarch64: add tests for FEAT_RME, Alex Bennée, 2025/01/08
- [PATCH v4 10/32] tests/functional: update the riscv32 tuxrun tests, Alex Bennée, 2025/01/08
- [PATCH v4 05/32] tests/functional: update the mips32el tuxrun tests, Alex Bennée, 2025/01/08
- [PATCH v4 16/32] tests/qtest: remove clock_steps from virtio tests, Alex Bennée, 2025/01/08
- [PATCH v4 21/32] tests/functional: remove unused kernel_command_line, Alex Bennée, 2025/01/08
- [PATCH v4 09/32] tests/functional: update the ppc64 tuxrun tests, Alex Bennée, 2025/01/08
- [PATCH v4 23/32] tests/functional: extend test_aarch64_virt with vulkan test, Alex Bennée, 2025/01/08