Re: [PATCH v4 19/32] tests/functional: add zstd support to uncompress utility

[Daniel P . Berrangé]

On Wed, Jan 08, 2025 at 12:10:41PM +0000, Alex Bennée wrote:
> Rather than using the python library (which has a different API
> anyway) lets just call the binary. zstdtools is already in out
> qemu.yml so all test containers should have it around. Tests should
> still use @skipIfMissingCommands('zstd') to gracefully handle when
> only minimal dependencies have been installed.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> ---
> v4
>   - add chmod step to helper
>   - also handle .zst extension
> ---
>  tests/functional/qemu_test/uncompress.py | 26 ++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 
> diff --git a/tests/functional/qemu_test/uncompress.py 
> b/tests/functional/qemu_test/uncompress.py
> index 6d02ded066..911d74ec23 100644
> --- a/tests/functional/qemu_test/uncompress.py
> +++ b/tests/functional/qemu_test/uncompress.py


> @@ -79,5 +101,9 @@ def guess_uncompress_format(compressed):
>          return "xz"
>      elif ext == ".gz":
>          return "gz"
> +    elif ext == ".zstd":
> +        return "zstd"
> +    elif ext == ".zst":
> +        return "zstd"

Or

  elif ext in [".zstd", ".zst"]:
      return 'zstd'

Either way, by R-b stands.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|