Re: [PATCH 3/3] target/cpus: Remove pointless re-assignment of CPUState::halted

[Richard Henderson]

On 12/30/24 07:39, Philippe Mathieu-Daudé wrote:
> The CPUState::halted field is always re-initialized in
> cpu_common_reset_hold(), itself called by cpu_reset().
> No need to have targets manually initializing it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/misc/mips_cpc.c        | 1 -
>   hw/ppc/e500.c             | 1 -
>   target/arm/arm-powerctl.c | 2 --
>   target/hppa/cpu.c         | 1 -
>   4 files changed, 5 deletions(-)

This is a behavior change if cpu->start_powered_off.

I think it's likely that "start powered off' should not apply to warm reset, and that 
otherwise this change is ok.  But I think there's that nit to address first.


r~