[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-riscv] [PATCH v1 0/2] RISC-V: Add default OpenSBI ROM
From: |
Peter Maydell |
Subject: |
Re: [Qemu-riscv] [PATCH v1 0/2] RISC-V: Add default OpenSBI ROM |
Date: |
Tue, 9 Jul 2019 09:37:08 +0100 |
On Tue, 9 Jul 2019 at 09:35, Palmer Dabbelt <address@hidden> wrote:
> I haven't looked at the code yet, but as the last one was fine it's probably
> OK. My only issue here is the timing: it's after the soft freeze so if I
> understand correctly we're not supposed to take any new features into 4.1.
> That's kind of unfortunate because it's somewhat unobtrusive and super useful.
>
> Peter: would you be OK taking this some time later this week? I'd want to dig
> through it and then bang on it a bit first. If not then I'll queue it up for
> 4.2.
The first attempt at putting this into master got onto the list before
freeze, so it's OK. Plus this clearly will only affect users using the
riscv boards, so it's a limited-scope change. So I think we're better
off putting it into 4.1 rather than not, assuming you're happy with
the level of testing it's had.
thanks
-- PMM