[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.0 02/12] hw/arm/bcm2835_peripherals: Add missing error-
From: |
Peter Maydell |
Subject: |
Re: [PATCH-for-5.0 02/12] hw/arm/bcm2835_peripherals: Add missing error-propagation code |
Date: |
Thu, 26 Mar 2020 21:34:19 +0000 |
On Wed, 25 Mar 2020 at 19:18, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Patch created mechanically by running:
>
> $ spatch \
> --macro-file scripts/cocci-macro-file.h --include-headers \
> --sp-file
> scripts/coccinelle/object_property_missing_error_propagate.cocci \
> --keep-comments --smpl-spacing --in-place --dir hw
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/arm/bcm2835_peripherals.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
> index edcaa4916d..a111e91069 100644
> --- a/hw/arm/bcm2835_peripherals.c
> +++ b/hw/arm/bcm2835_peripherals.c
> @@ -133,254 +133,262 @@ static void bcm2835_peripherals_init(Object *obj)
> static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp)
> {
> BCM2835PeripheralState *s = BCM2835_PERIPHERALS(dev);
> Object *obj;
> MemoryRegion *ram;
> Error *err = NULL;
> uint64_t ram_size, vcram_size;
> int n;
Is there a reason this patch has such an enormous amount of
context around the changes it's making ? It looks like it's
quoting the entire function.
Anyway
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [PATCH-for-5.0 00/12] hw: Add missing error-propagation code, Philippe Mathieu-Daudé, 2020/03/25
- [PATCH-for-5.0 01/12] scripts/coccinelle: Add script to catch missing error_propagate() calls, Philippe Mathieu-Daudé, 2020/03/25
- [PATCH-for-5.0 02/12] hw/arm/bcm2835_peripherals: Add missing error-propagation code, Philippe Mathieu-Daudé, 2020/03/25
- Re: [PATCH-for-5.0 02/12] hw/arm/bcm2835_peripherals: Add missing error-propagation code,
Peter Maydell <=
- [PATCH-for-5.0 05/12] hw/i386/x86: Add missing error-propagation code, Philippe Mathieu-Daudé, 2020/03/25
- [PATCH-for-5.0 04/12] hw/arm/stm32fx05_soc: Add missing error-propagation code, Philippe Mathieu-Daudé, 2020/03/25
- [PATCH-for-5.0 06/12] hw/dma/xilinx_axidma: Add missing error-propagation code, Philippe Mathieu-Daudé, 2020/03/25
- [PATCH-for-5.0 07/12] hw/mips/cps: Add missing error-propagation code, Philippe Mathieu-Daudé, 2020/03/25