[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FI
From: |
Thomas Huth |
Subject: |
Re: [PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FIXME |
Date: |
Wed, 15 Jul 2020 16:27:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 15/07/2020 16.04, Markus Armbruster wrote:
> nd_table[] contains NIC configuration for boards to pick up. Device
> code has no business looking there. Several devices do it anyway.
> Two of them already have a suitable FIXME comment: "allwinner-a10" and
> "msf2-soc". Copy it to the others: "allwinner-h3", "xlnx-versal",
> "xlnx,zynqmp", "sparc32-ledma", "riscv.sifive.u.soc".
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/arm/allwinner-h3.c | 1 +
> hw/arm/xlnx-versal.c | 1 +
> hw/arm/xlnx-zynqmp.c | 1 +
> hw/dma/sparc32_dma.c | 1 +
> hw/riscv/sifive_u.c | 1 +
> 5 files changed, 5 insertions(+)
Maybe we should add an entry to
https://wiki.qemu.org/Contribute/BiteSizedTasks for this?
Reviewed-by: Thomas Huth <thuth@redhat.com>
- [PATCH for-5.1 0/2] Unbreak make check SPEED=slow, Markus Armbruster, 2020/07/15
- [PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FIXME, Markus Armbruster, 2020/07/15
- [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc", Markus Armbruster, 2020/07/15
- Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc", Philippe Mathieu-Daudé, 2020/07/15
- Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc", Markus Armbruster, 2020/07/15
- Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc", sundeep subbaraya, 2020/07/15
- Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc", Thomas Huth, 2020/07/16
- Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc", Philippe Mathieu-Daudé, 2020/07/16
- Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc", sundeep subbaraya, 2020/07/16