Re: [PATCH] hw/intc: sifive_plic: Fix multi-socket plic configuraiton

[Alistair Francis]

On Tue, Jul 26, 2022 at 8:30 AM Atish Kumar Patra <atishp@rivosinc.com> wrote:
>
>
>
>
> On Sun, Jul 24, 2022 at 6:14 PM Alistair Francis <alistair23@gmail.com> wrote:
>>
>> On Sat, Jul 23, 2022 at 7:22 PM Atish Patra <atishp@rivosinc.com> wrote:
>> >
>> > Since commit 40244040a7ac, multi-socket configuration with plic is
>> > broken as the hartid for second socket is calculated incorrectly.
>> > The hartid stored in addr_config already includes the offset
>> > for the base hartid for that socket. Adding it again would lead
>> > to segfault while creating the plic device for the virt machine.
>> > qdev_connect_gpio_out was also invoked with incorrect number of gpio
>> > lines.
>> >
>> > Fixes: 40244040a7ac (hw/intc: sifive_plic: Avoid overflowing the 
>> > addr_config buffer)
>> >
>> > Signed-off-by: Atish Patra <atishp@rivosinc.com>
>>
>> Can you share the -cpu options that causes the segfault? I'll add it
>> to my test case
>>
>
> "-cpu rv64 -M virt -m 2G -smp 4 -object 
> memory-backend-ram,size=1G,policy=bind,host-nodes=0,id=ram-node0  \
> -numa node,memdev=ram-node0   \
> -object memory-backend-ram,size=1G,policy=bind,host-nodes=0,id=ram-node1 \
> -numa node,memdev=ram-node1"
>
> You also need to enable  CONFIG_NUMA in kernel.

Thanks!

Applied to riscv-to-apply.next

Alistair