Re: [RFC v2] linux-user/riscv: Add syscall riscv_hwprobe

[Robbin Ehn]

On Fri, 2023-06-02 at 20:00 -0700, Richard Henderson wrote:
> On 6/2/23 08:07, Andrew Jones wrote:
> > On Fri, Jun 02, 2023 at 04:39:20PM +0200, Robbin Ehn wrote:
> > > On Fri, 2023-06-02 at 16:02 +0200, Andrew Jones wrote:
> > > > On Fri, Jun 02, 2023 at 11:41:11AM +0200, Robbin Ehn wrote:
> > ...
> > > > > +#if defined(TARGET_RISCV)
> > > > > +    case TARGET_NR_riscv_hwprobe:
> > > > > +        {
> > > > 
> > > > The { goes under the c of case, which will shift all the below four 
> > > > spaces
> > > > left as well.
> > > 
> > > This was an attempt to blend in, i.e. same style as the preceding case.
> > > I'll change, thanks.
> > 
> > Hmm, I see. This function does have many cases with the indented format,
> > but not all of them, and the rest of the code base doesn't indent. I won't
> > insist on changing this, as long as checkpatch isn't complaining.
> 
> Splitting the entire thing out to a helper function is even cleaner.
> We have lots of those, but certainly not universal.

This was my initial reaction, even move something out of this file.
Yes I'll put it in a helper.

Thank you!

/Robbin

> 
> I have, from time to time, tried to clean all of this up, but no one wanted 
> to look at a 
> 100+ RFC patch set which only scratched the surface.
> 
> 
> r~
>