Re: [PATCH v2] dt-bindings: riscv: deprecate riscv,isa

[Conor Dooley]

On Thu, Jun 08, 2023 at 11:49:08AM -0600, Rob Herring wrote:
> On Thu, 08 Jun 2023 17:54:05 +0100, Conor Dooley wrote:

> > As a result of implementing Sean's suggestion, I believe I need to add
> > riscv,isa-extensions as an exception to the rules preventing vendor
> > properties being of object type, otherwise dt_binding_check is less than
> > happy with me.

> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/extensions.yaml:
>  properties:riscv,isa-extensions: 'oneOf' conditional failed, one must be 
> fixed:
>       Additional properties are not allowed ('additionalProperties', 
> 'properties' were unexpected)
>               hint: A vendor boolean property can use "type: boolean"
>       
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/extensions.yaml:
>  properties:riscv,isa-extensions: 'oneOf' conditional failed, one must be 
> fixed:
>               'enum' is a required property
>               'const' is a required property
>               hint: A vendor string property with exact values has an 
> implicit type
>               from schema $id: 
> http://devicetree.org/meta-schemas/vendor-props.yaml#
>       Additional properties are not allowed ('additionalProperties', 
> 'properties', 'type' were unexpected)
>               hint: A vendor string property with exact values has an 
> implicit type
>       
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/extensions.yaml:
>  properties:riscv,isa-extensions: 'oneOf' conditional failed, one must be 
> fixed:
>               '$ref' is a required property
>               'allOf' is a required property
>               hint: A vendor property needs a $ref to types.yaml
>               from schema $id: 
> http://devicetree.org/meta-schemas/vendor-props.yaml#
>       'boolean' was expected
>               hint: A vendor boolean property can use "type: boolean"
>       hint: Vendor specific properties must have a type and description 
> unless they have a defined, common suffix.
>       from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#

Yeah, expected. I think I need an exception in vendor-props for this to
pass the checks.

signature.asc
Description: PGP signature