[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] rust/pl011: Fix DeviceID reads
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v3] rust/pl011: Fix DeviceID reads |
|
Date: |
Mon, 18 Nov 2024 13:40:33 +0100 |
On Mon, Nov 18, 2024 at 12:41 PM Alex Bennée <alex.bennee@linaro.org> wrote:
> This is a nice improvement in conciseness over the separate legs removed
> bellow.
>
> > + eprintln!("write bad offset {offset} at RO register
> > {dev_id:?} value {value}");
> > + }
>
> Is a binding for qemu_log and friends on the todo list?
Yes, see
https://lore.kernel.org/qemu-devel/20241024-rust-round-2-v1-10-051e7a25b978@linaro.org/
and my concerns at
https://lore.kernel.org/qemu-devel/e8e55772-906b-42cb-a744-031e6ae65f16@redhat.com/.
More reviews are welcome; in general, we should define a convention
for Rust functions and constants (is it okay to rename constants in
the Rust bindings if their C name is ugly? should functions keep or
lose the "qemu_*" prefixes?).
The corresponding patch to move from "eprintln!" to the logging
functions is at
https://lore.kernel.org/qemu-devel/20241024-rust-round-2-v1-11-051e7a25b978@linaro.org/.
Paolo