[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/39] tests/functional: honour requested test VM name in QEMUMac
From: |
Alex Bennée |
Subject: |
[PATCH 10/39] tests/functional: honour requested test VM name in QEMUMachine |
Date: |
Thu, 21 Nov 2024 16:57:37 +0000 |
From: Daniel P. Berrangé <berrange@redhat.com>
The functional test case class is going to the trouble of passing
around a machine name, but then fails to give this QEMUMachine. As
a result, QEMUMachine will create a completely random name. Since
log file names match the machine name, this results in log files
accumulating over time.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20241121154218.1423005-11-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/functional/qemu_test/testcase.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/functional/qemu_test/testcase.py
b/tests/functional/qemu_test/testcase.py
index ca13af244b..f9c9de1166 100644
--- a/tests/functional/qemu_test/testcase.py
+++ b/tests/functional/qemu_test/testcase.py
@@ -164,6 +164,7 @@ def require_device(self, devicename):
def _new_vm(self, name, *args):
vm = QEMUMachine(self.qemu_bin,
+ name=name,
base_temp_dir=self.workdir,
log_dir=self.logdir)
self.log.debug('QEMUMachine "%s" created', name)
--
2.39.5
- [PATCH 00/39] maintainer updates for -rc2 pre-PR, Alex Bennée, 2024/11/21
- [PATCH 03/39] tests/functional: remove "AVOCADO" from env variable name, Alex Bennée, 2024/11/21
- [PATCH 02/39] tests/functional: automatically clean up scratch files after tests, Alex Bennée, 2024/11/21
- [PATCH 01/39] tests/functional: fix mips64el test to honour workdir, Alex Bennée, 2024/11/21
- [PATCH 04/39] tests/functional: remove todo wrt avocado.utils.wait_for, Alex Bennée, 2024/11/21
- [PATCH 05/39] tests/functional: remove leftover :avocado: tags, Alex Bennée, 2024/11/21
- [PATCH 07/39] tests/functional: remove comments talking about avocado, Alex Bennée, 2024/11/21
- [PATCH 10/39] tests/functional: honour requested test VM name in QEMUMachine,
Alex Bennée <=
- [PATCH 08/39] tests/functional: honour self.workdir in ACPI bits tests, Alex Bennée, 2024/11/21
- [PATCH 06/39] tests/functional: remove obsolete reference to avocado bug, Alex Bennée, 2024/11/21
- [PATCH 09/39] tests/functional: put QEMUMachine logs in testcase log directory, Alex Bennée, 2024/11/21
- [PATCH 13/39] tests/functional: don't try to wait for the empty string, Alex Bennée, 2024/11/21
- [PATCH 16/39] tests/functional: remove time.sleep usage from tuxrun tests, Alex Bennée, 2024/11/21
- [PATCH 31/39] tests/functional: update the riscv64 tuxrun tests, Alex Bennée, 2024/11/21
- [PATCH 30/39] tests/functional: update the riscv32 tuxrun tests, Alex Bennée, 2024/11/21