[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 13/39] tests/functional: don't try to wait for the empty string
From: |
Alex Bennée |
Subject: |
[PATCH 13/39] tests/functional: don't try to wait for the empty string |
Date: |
Thu, 21 Nov 2024 16:57:40 +0000 |
From: Daniel P. Berrangé <berrange@redhat.com>
Telling exec_command_wand_wait_for_pattern to wait for the empty
string does not make any conceptual sense, as a check for empty
string will always succeed. It makes even less sense when followed
by a call to wait_for_console_pattern() with a real match.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20241121154218.1423005-14-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/functional/test_virtio_gpu.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/functional/test_virtio_gpu.py
b/tests/functional/test_virtio_gpu.py
index 441cbdcf2d..d5027487ac 100755
--- a/tests/functional/test_virtio_gpu.py
+++ b/tests/functional/test_virtio_gpu.py
@@ -80,9 +80,8 @@ def test_virtio_vga_virgl(self):
self.wait_for_console_pattern("as init process")
exec_command_and_wait_for_pattern(
- self, "/usr/sbin/modprobe virtio_gpu", ""
+ self, "/usr/sbin/modprobe virtio_gpu", "features: +virgl +edid"
)
- self.wait_for_console_pattern("features: +virgl +edid")
def test_vhost_user_vga_virgl(self):
# FIXME: should check presence of vhost-user-gpu, virgl, memfd etc
--
2.39.5
- [PATCH 02/39] tests/functional: automatically clean up scratch files after tests, (continued)
- [PATCH 02/39] tests/functional: automatically clean up scratch files after tests, Alex Bennée, 2024/11/21
- [PATCH 01/39] tests/functional: fix mips64el test to honour workdir, Alex Bennée, 2024/11/21
- [PATCH 04/39] tests/functional: remove todo wrt avocado.utils.wait_for, Alex Bennée, 2024/11/21
- [PATCH 05/39] tests/functional: remove leftover :avocado: tags, Alex Bennée, 2024/11/21
- [PATCH 07/39] tests/functional: remove comments talking about avocado, Alex Bennée, 2024/11/21
- [PATCH 10/39] tests/functional: honour requested test VM name in QEMUMachine, Alex Bennée, 2024/11/21
- [PATCH 08/39] tests/functional: honour self.workdir in ACPI bits tests, Alex Bennée, 2024/11/21
- [PATCH 06/39] tests/functional: remove obsolete reference to avocado bug, Alex Bennée, 2024/11/21
- [PATCH 09/39] tests/functional: put QEMUMachine logs in testcase log directory, Alex Bennée, 2024/11/21
- [PATCH 13/39] tests/functional: don't try to wait for the empty string,
Alex Bennée <=
- [PATCH 16/39] tests/functional: remove time.sleep usage from tuxrun tests, Alex Bennée, 2024/11/21
- [PATCH 31/39] tests/functional: update the riscv64 tuxrun tests, Alex Bennée, 2024/11/21
- [PATCH 30/39] tests/functional: update the riscv32 tuxrun tests, Alex Bennée, 2024/11/21
- [PATCH 11/39] tests/functional: enable debug logging for QEMUMachine, Alex Bennée, 2024/11/21
- [PATCH 14/39] tests/functional: require non-NULL success_message for console wait, Alex Bennée, 2024/11/21