qemu-rust
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] rust: include rust_version in Cargo.toml


From: Zhao Liu
Subject: Re: [PATCH 2/2] rust: include rust_version in Cargo.toml
Date: Thu, 6 Feb 2025 19:02:05 +0800

> diff --git a/rust/hw/char/pl011/src/device_class.rs 
> b/rust/hw/char/pl011/src/device_class.rs
> index 8a157a663fb..dbef93f6cb3 100644
> --- a/rust/hw/char/pl011/src/device_class.rs
> +++ b/rust/hw/char/pl011/src/device_class.rs
> @@ -12,7 +12,6 @@
>  
>  use crate::device::{PL011Registers, PL011State};
>  
> -#[allow(clippy::missing_const_for_fn)]

It seems like a rebase nit since the commit 7d0520398f7f ("rust: prefer
NonNull::new to assertions"), which is not worth an extra commit either.

>  extern "C" fn pl011_clock_needed(opaque: *mut c_void) -> bool {
>      let state = NonNull::new(opaque).unwrap().cast::<PL011State>();
>      unsafe { state.as_ref().migrate_clock }

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]