Re: [PATCH 04/18] tests/qtest: simplify qtest_process

qemu-rust

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/18] tests/qtest: simplify qtest_process_inbuf

From:	Peter Maydell
Subject:	Re: [PATCH 04/18] tests/qtest: simplify qtest_process_inbuf
Date:	Thu, 6 Feb 2025 15:50:55 +0000

On Mon, 3 Feb 2025 at 14:41, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Don't both creating a GString to temporarily hold our qtest command.
> Instead do a simpler g_strndup and use autofree to clean up
> afterwards.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---


Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 00/18] maintainer updates for feb25 (qtest, gdbstub, plugins), Alex Bennée, 2025/02/03
- [PATCH 03/18] tests/qtest: don't step clock at start of npcm7xx periodic IRQ test, Alex Bennée, 2025/02/03
- [PATCH 01/18] tests/docker: replicate the check-rust-tools-nightly CI job, Alex Bennée, 2025/02/03
- [PATCH 02/18] tests/qtest: don't attempt to clock_step while waiting for virtio ISR, Alex Bennée, 2025/02/03
- [PATCH 05/18] tests/qtest: rename qtest_send_prefix and roll-up into qtest_send, Alex Bennée, 2025/02/03
- [PATCH 04/18] tests/qtest: simplify qtest_process_inbuf, Alex Bennée, 2025/02/03
  - Re: [PATCH 04/18] tests/qtest: simplify qtest_process_inbuf, Peter Maydell <=
- [PATCH 10/18] gdbstub: Allow the %d placeholder in the socket path, Alex Bennée, 2025/02/03
- [PATCH 07/18] Revert "util/timer: avoid deadlock when shutting down", Alex Bennée, 2025/02/03
  - Re: [PATCH 07/18] Revert "util/timer: avoid deadlock when shutting down", Peter Maydell, 2025/02/06
- [PATCH 14/18] osdep: Introduce qemu_kill_thread(), Alex Bennée, 2025/02/03
- [PATCH 06/18] tests/qtest: tighten up the checks on clock_step, Alex Bennée, 2025/02/03
  - Re: [PATCH 06/18] tests/qtest: tighten up the checks on clock_step, Peter Maydell, 2025/02/06
- [PATCH 12/18] user: Introduce user/signal.h, Alex Bennée, 2025/02/03
- [PATCH 08/18] tests/qtest/migration: Add --full option, Alex Bennée, 2025/02/03
- [PATCH 13/18] user: Introduce host_interrupt_signal, Alex Bennée, 2025/02/03
- [PATCH 15/18] gdbstub: Allow late attachment, Alex Bennée, 2025/02/03

Prev by Date: Re: [PATCH] rust: add --rust-target option for bindgen
Next by Date: Re: [PATCH 06/18] tests/qtest: tighten up the checks on clock_step
Previous by thread: [PATCH 04/18] tests/qtest: simplify qtest_process_inbuf
Next by thread: [PATCH 10/18] gdbstub: Allow the %d placeholder in the socket path
Index(es):
- Date
- Thread