[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/11] rust: Add some block layer bindings
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 03/11] rust: Add some block layer bindings |
Date: |
Wed, 12 Feb 2025 20:52:50 +0100 |
Am 12.02.2025 um 18:16 hat Paolo Bonzini geschrieben:
> On 2/12/25 16:13, Kevin Wolf wrote:
> > Or if you have to define the constants anyway - you currently do this
> > only for Windows, but for into_negative_errno() you might need it on
> > Linux, too - and it wouldn't be a problem for the constants to be
> > signed (that they are unsigned is the main reason why it becomes so ugly
> > with the bindgen constants), you could just make it -errno::EINVAL
> > again.
>
> Or just include the libc crate, see attachment.
I assume that sooner or later we'll have a reason to include it anyway,
so that might honestly be the best option.
Do you want to post it as a proper patch? It seems to depend on your
errno patch, but that shouldn't be a problem because we still want that
one, too.
Kevin
- Re: [PATCH 10/11] bochs-rs: Add bochs block driver reimplementation in Rust, (continued)
[PATCH 07/11] block: Add bdrv_open_blockdev_ref_file(), Kevin Wolf, 2025/02/11
[PATCH 03/11] rust: Add some block layer bindings, Kevin Wolf, 2025/02/11
- Re: [PATCH 03/11] rust: Add some block layer bindings, Paolo Bonzini, 2025/02/12
- Re: [PATCH 03/11] rust: Add some block layer bindings, Kevin Wolf, 2025/02/12
- Re: [PATCH 03/11] rust: Add some block layer bindings, Paolo Bonzini, 2025/02/12
- Re: [PATCH 03/11] rust: Add some block layer bindings, Kevin Wolf, 2025/02/12
- Re: [PATCH 03/11] rust: Add some block layer bindings, Paolo Bonzini, 2025/02/12
- Re: [PATCH 03/11] rust: Add some block layer bindings,
Kevin Wolf <=
- Re: [PATCH 03/11] rust: Add some block layer bindings, Paolo Bonzini, 2025/02/13
[PATCH 05/11] rust/block: Add empty crate, Kevin Wolf, 2025/02/11
[PATCH 11/11] rust/block: Add format probing, Kevin Wolf, 2025/02/11
[PATCH 04/11] rust/qemu-api: Add wrappers to run futures in QEMU, Kevin Wolf, 2025/02/11
[PATCH 09/11] rust/block: Add read support for block drivers, Kevin Wolf, 2025/02/11